Skip to content

Conversation

@pierre-eliep-met
Copy link
Collaborator

@pierre-eliep-met pierre-eliep-met commented Sep 19, 2022

Goal

Simply fixes #280 by renaming P_psi to P_psiA

Type of change

  • Bugfix (non-breaking change which fixes a bug/issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change which reorganizes code)
  • Release & Version Update (when cumulative changes justify a release)
  • Documentation Update

Checklist

You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.

GitHub checks:

  • I have added the appropriate tags, reviewers, projects and linked issues to this PR
  • I have checked for conflicts with target branch, and merged/rebased in consequence

Model development checks:

  • I have performed a self-review of my own code
  • I have checked that my changes do not bring any retrocompatibility issue comparing to MML3-DTG-v3 version
  • Existing tests pass (including Metroscopia !).
  • I have added/updated tests that prove my development works and does not break anything.

Library checks:

  • I have checked in the file explorer that I am not adding duplicate file/folder/package (due to renaming or moving file/package)
  • I have checked that the packages I upload are stored as separate files

Documentation checks:

  • I have made corresponding changes or additions to the documentation
  • I have added corresponding entries to the Changelog

Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
@pierre-eliep-met pierre-eliep-met added 💔 No retro compatibility For changes that break retrocompatibility 🔢 Declaration Changes related to unit/start/nominal/min/max labels Sep 19, 2022
@pierre-eliep-met pierre-eliep-met self-assigned this Sep 19, 2022
@pierre-eliep-met pierre-eliep-met added the 🗃️skip-changelog Changes that should be omitted from the release notes label Sep 19, 2022
@pierre-eliep-met pierre-eliep-met added this to the MML3 Publication milestone Sep 22, 2022
@valentind-met
Copy link
Contributor

What are the consequences on the current models ?

@pierre-eliep-met
Copy link
Collaborator Author

None, this is only renaming start values from the with_start_values models in the examples. Current models already contain the correct naming

@pierre-eliep-met
Copy link
Collaborator Author

pierre-eliep-met commented Oct 3, 2022

I will force merging since since this PR is really a minor changed and it is needed to publish MML3. (benediction from @hvernier 😇 )

Copy link
Collaborator Author

@pierre-eliep-met pierre-eliep-met left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, just renaming

@pierre-eliep-met pierre-eliep-met merged commit efd7cc0 into mml3-main Oct 3, 2022
@pierre-eliep-met pierre-eliep-met deleted the fix-psia-psig-renaming branch October 3, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💔 No retro compatibility For changes that break retrocompatibility 🗃️skip-changelog Changes that should be omitted from the release notes 🔢 Declaration Changes related to unit/start/nominal/min/max

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] P_psi renamed to P_psiG and P_psiA created retrocompatibility issues

3 participants