Skip to content

Conversation

@pierre-eliep-met
Copy link
Collaborator

@pierre-eliep-met pierre-eliep-met commented Sep 12, 2022

Goal

Trying to fix #99 by adding a not_used effort variable into power connectors.

Type of change

  • Bugfix (non-breaking change which fixes a bug/issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change which reorganizes code)
  • Release & Version Update (when cumulative changes justify a release)
  • Documentation Update

Checklist

You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.

GitHub checks:

  • I have added the appropriate tags, reviewers, projects and linked issues to this PR
  • I have checked for conflicts with target branch, and merged/rebased in consequence

Model development checks:

  • I have performed a self-review of my own code
  • I have checked that my changes do not bring any retrocompatibility issue comparing to MML3-DTG-v3 version
  • Existing tests pass (including Metroscopia !).
  • I have added/updated tests that prove my development works and does not break anything.

Library checks:

  • I have checked in the file explorer that I am not adding duplicate file/folder/package (due to renaming or moving file/package)
  • I have checked that the packages I upload are stored as separate files

Documentation checks:

  • I have made corresponding changes or additions to the documentation
  • I have added corresponding entries to the Changelog

Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
@pierre-eliep-met pierre-eliep-met added the ⚖️ Local Balance Component is not locally balanced label Sep 12, 2022
@pierre-eliep-met pierre-eliep-met self-assigned this Sep 12, 2022
Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
@pierre-eliep-met pierre-eliep-met marked this pull request as ready for review September 12, 2022 13:51
valentind-met
valentind-met previously approved these changes Sep 23, 2022
Copy link
Contributor

@valentind-met valentind-met left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for now. I still think we should find a better option.

@pierre-eliep-met pierre-eliep-met marked this pull request as ready for review October 17, 2022 14:02
@pierre-eliep-met pierre-eliep-met marked this pull request as draft October 17, 2022 14:09
@pierre-eliep-met
Copy link
Collaborator Author

This PR will be merged when we have a turbopump component, so that we don't hav any problem with turbopumps in our models

Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
pierre-eliep-met and others added 2 commits October 26, 2022 14:19
@pierre-eliep-met
Copy link
Collaborator Author

@casella & @AndreaBartolini I am trying to complete this PR so that it fixes the issue and all the related ones.

But I had a problem : I cannot set dummy=0 in the power connector of MetroscopeModelingLibrary/FlueGases/Machines/AirCompressor.mo, because otherwise it is not balanced. I think this is due to the fact that the compresser sets the power it needs based on its efficiency. But then we cannot set dummy (if it is actually the cause)

In fact this is a bit the same problem as for the turbopump I think @valentindrou...

@AndreaBartolini
Copy link
Contributor

AndreaBartolini commented Nov 11, 2022

It is exactly the same of the turbopump, if the compressor sets the power then it cannot set also the dummy variable. If there is a scenario like the turbopump in that the compressor works at "load" then you need another specialized component (like turbopump)

Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
@pierre-eliep-met
Copy link
Collaborator Author

Agreed, We've done a workaround with a Interfaces.RealInput/Output. We could not do this before with the turbopump because we needed the same power connector in the steam turbine case, so the dedicated component will be fine there.

@pierre-eliep-met pierre-eliep-met marked this pull request as ready for review November 14, 2022 10:14
@pierre-eliep-met pierre-eliep-met dismissed valentind-met’s stale review November 14, 2022 10:21

This review is outdated and we need a new one

@pierre-eliep-met
Copy link
Collaborator Author

@valentindrou I will add the Turbopump component, no need for a review yet then

@pierre-eliep-met
Copy link
Collaborator Author

I am closing this PR since it is now completely outdated, and restarting from the beginning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚖️ Local Balance Component is not locally balanced

Projects

None yet

5 participants