-
Notifications
You must be signed in to change notification settings - Fork 2
Fix power connector balance #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
valentind-met
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for now. I still think we should find a better option.
|
This PR will be merged when we have a turbopump component, so that we don't hav any problem with turbopumps in our models |
Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
|
@casella & @AndreaBartolini I am trying to complete this PR so that it fixes the issue and all the related ones. But I had a problem : I cannot set In fact this is a bit the same problem as for the turbopump I think @valentindrou... |
|
It is exactly the same of the turbopump, if the compressor sets the power then it cannot set also the dummy variable. If there is a scenario like the turbopump in that the compressor works at "load" then you need another specialized component (like turbopump) |
Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
|
Agreed, We've done a workaround with a |
This review is outdated and we need a new one
|
@valentindrou I will add the Turbopump component, no need for a review yet then |
|
I am closing this PR since it is now completely outdated, and restarting from the beginning |
Goal
Trying to fix #99 by adding a
not_usedeffort variable into power connectors.Type of change
Checklist
You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.
GitHub checks:
Model development checks:
Library checks:
Documentation checks: