-
Notifications
You must be signed in to change notification settings - Fork 2
added : LMTD heat exchange function, LMTDfuelHeater componenent and u… #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MetroscopeModelingLibrary/Power/HeatExchange/LMTDHeatExchange.mo
Outdated
Show resolved
Hide resolved
MetroscopeModelingLibrary/Tests/Multifluid/HeatExchangers/FuelHeater_reverse.mo
Outdated
Show resolved
Hide resolved
MetroscopeModelingLibrary/Tests/Multifluid/HeatExchangers/FuelHeater_reverse.mo
Outdated
Show resolved
Hide resolved
MetroscopeModelingLibrary/Tests/Multifluid/HeatExchangers/LMTDFuelHeater_reverse.mo
Outdated
Show resolved
Hide resolved
...copeModelingLibrary/Tests/Power/HeatExchange/LMTD_HeatExchange_monophasic_counter_current.mo
Show resolved
Hide resolved
MetroscopeModelingLibrary/Power/HeatExchange/LMTDHeatExchange.mo
Outdated
Show resolved
Hide resolved
pierre-eliep-met
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry I added many comments that I could have added before, I'm still learning this process, sorry for the additionnal work
MetroscopeModelingLibrary/MultiFluid/HeatExchangers/LMTDFuelHeater.mo
Outdated
Show resolved
Hide resolved
MetroscopeModelingLibrary/Power/HeatExchange/LMTDHeatExchange.mo
Outdated
Show resolved
Hide resolved
MetroscopeModelingLibrary/Power/HeatExchange/LMTDHeatExchange.mo
Outdated
Show resolved
Hide resolved
MetroscopeModelingLibrary/Tests/Multifluid/HeatExchangers/package.order
Outdated
Show resolved
Hide resolved
...copeModelingLibrary/Tests/Power/HeatExchange/LMTD_HeatExchange_monophasic_counter_current.mo
Show resolved
Hide resolved
Signed-off-by: Helene Vernier <helene.vernier@metroscope.tech>
Signed-off-by: Helene Vernier <helene.vernier@metroscope.tech>
Signed-off-by: Helene Vernier <helene.vernier@metroscope.tech>
Signed-off-by: Helene Vernier <helene.vernier@metroscope.tech>
Co-authored-by: pepmts <97044708+pepmts@users.noreply.github.com>
pierre-eliep-met
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments again 😇
Almost there 😇
MetroscopeModelingLibrary/MultiFluid/HeatExchangers/LMTDFuelHeater.mo
Outdated
Show resolved
Hide resolved
MetroscopeModelingLibrary/MultiFluid/HeatExchangers/LMTDFuelHeater.mo
Outdated
Show resolved
Hide resolved
MetroscopeModelingLibrary/MultiFluid/HeatExchangers/LMTDFuelHeater.mo
Outdated
Show resolved
Hide resolved
MetroscopeModelingLibrary/MultiFluid/HeatExchangers/LMTDFuelHeater.mo
Outdated
Show resolved
Hide resolved
MetroscopeModelingLibrary/MultiFluid/HeatExchangers/LMTDFuelHeater.mo
Outdated
Show resolved
Hide resolved
MetroscopeModelingLibrary/MultiFluid/HeatExchangers/LMTDFuelHeater.mo
Outdated
Show resolved
Hide resolved
MetroscopeModelingLibrary/MultiFluid/HeatExchangers/LMTDFuelHeater.mo
Outdated
Show resolved
Hide resolved
MetroscopeModelingLibrary/Power/HeatExchange/LMTDHeatExchange.mo
Outdated
Show resolved
Hide resolved
MetroscopeModelingLibrary/Power/HeatExchange/LMTDHeatExchange.mo
Outdated
Show resolved
Hide resolved
pierre-eliep-met
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
…nit test
Goal
Describe the big picture of your changes here (one sentence).
If it fixes a bug or resolves a feature request, be sure to link to that issue (click here to know how to do that ?).
Type of change
Checklist
You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.
GitHub checks:
Model development checks:
Library checks:
Documentation checks: