Skip to content

Conversation

@helenev-met
Copy link
Contributor

@helenev-met helenev-met commented Jul 27, 2022

…nit test

Goal

Describe the big picture of your changes here (one sentence).
If it fixes a bug or resolves a feature request, be sure to link to that issue (click here to know how to do that ?).

Type of change

  • Bugfix (non-breaking change which fixes a bug/issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change which reorganizes code)
  • Release & Version Update (when cumulative changes justify a release)
  • Documentation Update

Checklist

You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.

GitHub checks:

  • I have added the appropriate tags, reviewers, projects and linked issues to this PR
  • I have checked for conflicts with target branch, and merged/rebased in consequence

Model development checks:

  • I have performed a self-review of my own code
  • I have checked that my changes do not bring any retrocompatibility issue comparing to MML3-DTG-v3 version
  • Existing tests pass (including Metroscopia !).
  • I have added/updated tests that prove my development works and does not break anything.

Library checks:

  • I have checked in the file explorer that I am not adding duplicate file/folder/package (due to renaming or moving file/package)
  • I have checked that the packages I upload are stored as separate files

Documentation checks:

  • I have made corresponding changes or additions to the documentation
  • I have added corresponding entries to the Changelog

@helenev-met helenev-met added 🧪testing Adding missing tests or correcting existing tests 🆕 New component For new components added to the library labels Jul 27, 2022
@helenev-met helenev-met self-assigned this Jul 27, 2022
@pierre-eliep-met pierre-eliep-met requested review from pierre-eliep-met and valentind-met and removed request for pierre-eliep-met July 27, 2022 15:33
Copy link
Collaborator

@pierre-eliep-met pierre-eliep-met left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry I added many comments that I could have added before, I'm still learning this process, sorry for the additionnal work

@pierre-eliep-met pierre-eliep-met added this to the MML3 Publication milestone Sep 22, 2022
helenev-met and others added 6 commits September 23, 2022 14:39
Signed-off-by: Helene Vernier <helene.vernier@metroscope.tech>
Signed-off-by: Helene Vernier <helene.vernier@metroscope.tech>
Signed-off-by: Helene Vernier <helene.vernier@metroscope.tech>
Signed-off-by: Helene Vernier <helene.vernier@metroscope.tech>
Co-authored-by: pepmts <97044708+pepmts@users.noreply.github.com>
Copy link
Collaborator

@pierre-eliep-met pierre-eliep-met left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments again 😇
Almost there 😇

Copy link
Collaborator

@pierre-eliep-met pierre-eliep-met left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@helenev-met helenev-met merged commit ef07fe5 into mml3-main Oct 3, 2022
@helenev-met helenev-met deleted the HV_fuelHeater branch October 3, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🆕 New component For new components added to the library 🧪testing Adding missing tests or correcting existing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants