fix: add useExternalService as option in assetSelector #7545
+92
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR adds a useExternalServices option to the token selectors, allowing callers to exclude non-EVM (multichain) assets when basic functionality / external services are disabled.
Added a useExternalServices option that:
Short-circuits early in
selectAllMultichainAssetswhenfalse, returning an empty object immediatelyAvoids all expensive computation (parsing CAIP assets, building balances, fiat conversions) when multichain assets aren't needed
Defaults to true to maintain backward compatibility
References
Checklist
Note
Adds a
useExternalServicesoption to asset selectors to optionally exclude non‑EVM assets and short‑circuit multichain processing; updates tests and changelog.useExternalServicesoption toselectAllAssetsandselectAssetsBySelectedAccountGroup(defaults totrue).selectAllMultichainAssets, return{}whenuseExternalServicesisfalse, excluding non‑EVM (multichain) assets.optsthrough selectors to control inclusion of multichain assets.packages/assets-controllers/src/selectors/token-selectors.test.ts)useExternalServicesand default behavior.useExternalServiceswhere needed.useExternalServicesoption and behavior inpackages/assets-controllers/CHANGELOG.md.Written by Cursor Bugbot for commit a6eea22. This will update automatically on new commits. Configure here.