feat: CowSwap intent base swap #6547
Draft
+2,667
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawnseeker8
commented
Sep 10, 2025
micaelae
reviewed
Dec 17, 2025
oscarwroche
force-pushed
the
wip/intent-swap-architecture-refactory
branch
from
852c2ca to
3db0fcf
Compare
refactor: intent api in utils with validators
oscarwroche
force-pushed
the
wip/intent-swap-architecture-refactory
branch
from
3db0fcf to
546dc9d
Compare
oscarwroche
force-pushed
the
wip/intent-swap-architecture-refactory
branch
from
d913692 to
6cfc1db
Compare
oscarwroche
force-pushed
the
wip/intent-swap-architecture-refactory
branch
from
3f2ec7d to
4b28212
Compare
micaelae
reviewed
Dec 19, 2025
Comment on lines
1703
to
1714
| const intentTransactionParams = { | ||
| chainId: formatChainIdToHex(chainId), | ||
| from: accountAddress, | ||
| to: | ||
| intent.settlementContract ?? | ||
| '0x9008D19f58AAbd9eD0D60971565AA8510560ab41', // Default settlement contract | ||
| data: `0x${orderUid.slice(-8)}`, // Use last 8 chars of orderUid to make each transaction unique | ||
| value: '0x0', | ||
| gas: '0x5208', // Minimal gas for display purposes | ||
| gasPrice: '0x3b9aca00', // 1 Gwei - will be converted to EIP-1559 fees if network supports it | ||
| skipInitialGasEstimate: true, | ||
| }; |
Member
There was a problem hiding this comment.
What does this transaction do? Is it a noop transaction that costs gas? If I'm understanding the usage correctly, it's purpose is to add a tx to history + TransactionController, which the frontend can use to show the intent order's status in the activity list
There was a problem hiding this comment.
This is the transaction's purpose indeed. I'll add a comment to clarify what it's for.
Contributor
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
oscarwroche
force-pushed
the
wip/intent-swap-architecture-refactory
branch
from
468477b to
f620f5d
Compare
Akaryatrh
requested changes
Dec 22, 2025
Comment on lines
1248
to
+1250
| maxFeePerGas: toHex(txFee.maxFeePerGas ?? 0), | ||
| maxPriorityFeePerGas: toHex(txFee.maxPriorityFeePerGas ?? 0), | ||
| gas: maxGasLimit, | ||
| gas: transactionParams.gas ? toHex(transactionParams.gas) : undefined, |
Contributor
There was a problem hiding this comment.
@oscarwroche Can you store it back in a const?
const maxGasLimit = transactionParams.gas ? toHex(transactionParams.gas) : undefined;
Also can you explain why is it fixing the gas issue we had?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist