Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions M2/Macaulay2/packages/NormalToricVarieties/ToricVarieties.m2
Original file line number Diff line number Diff line change
Expand Up @@ -673,8 +673,10 @@ makePrimitive List := List => w -> (
apply(w, i -> i // g)
);

toricBlowup = method ()
toricBlowup (List, NormalToricVariety, List) := NormalToricVariety => (s, X, v) -> (
toricBlowup = method(Options => { WeilToClass => null })
toricBlowup(List, NormalToricVariety) := NormalToricVariety => opts -> (s, X) -> (
toricBlowup(s, X, makePrimitive sum ((rays X)_s), opts))
toricBlowup(List, NormalToricVariety, List) := NormalToricVariety => opts -> (s, X, v) -> (
coneList := max X;
starIndex := positions (coneList, t -> all (s, i -> member (i,t)));
star := coneList_starIndex;
Expand All @@ -693,24 +695,25 @@ toricBlowup (List, NormalToricVariety, List) := NormalToricVariety => (s, X, v)
if member (s#0,t) then continue
else sort (t | s)
);
Z := normalToricVariety (rays X, coneList | coneList', CoefficientRing => X.cache.CoefficientRing, Variable => X.cache.Variable);
Z := normalToricVariety(rays X, coneList | coneList',
CoefficientRing => X.cache.CoefficientRing,
Variable => X.cache.Variable,
WeilToClass => opts.WeilToClass);
Z.cache.toricBlowup = X;
return Z
);
coneList' = for t in clStar list (
if all (s, i -> member (i,t)) then continue
else t | {n}
);
Z = normalToricVariety (rays X | {v}, coneList | coneList', CoefficientRing => X.cache.CoefficientRing, Variable => X.cache.Variable);
Z = normalToricVariety(rays X | {v}, coneList | coneList',
CoefficientRing => X.cache.CoefficientRing,
Variable => X.cache.Variable,
WeilToClass => opts.WeilToClass);
Z.cache.toricBlowup = X;
Z
);

toricBlowup (List, NormalToricVariety) := NormalToricVariety => (s,X) -> (
v := makePrimitive sum ((rays X)_s);
toricBlowup (s,X,v)
);

makeSmooth = method(
TypicalValue => NormalToricVariety,
Options => {Strategy => 0}
Expand Down
1 change: 0 additions & 1 deletion M2/Macaulay2/packages/Varieties.m2
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ export {
-- Functors
"hh", -- TODO: should this be defined in Core?
"OO",
"RHom",
-- Symbols
"GlobalSectionLimit",
"SaturationMap",
Expand Down
1 change: 1 addition & 0 deletions M2/Macaulay2/packages/Varieties/SheafComplexes.m2
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
export {
"RHom",
}

-----------------------------------------------------------------------------
Expand Down
17 changes: 6 additions & 11 deletions M2/Macaulay2/packages/Varieties/SheafMaps.m2
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,14 @@ export {
-- Types
"SheafMap",
-- Methods
"sheafMap",
-- "isLiftable",
"yonedaSheafExtension",
-- "yonedaSheafExtension",
-- "yonedaSheafExtension'",
"cotangentSurjection",
"eulerSequence",
"idealSheafSequence",
"embeddedToAbstract",
"ExtLongExactSequence",
-- "cotangentSurjection",
-- "eulerSequence",
-- "idealSheafSequence",
-- "embeddedToAbstract",
-- "ExtLongExactSequence",
}

-----------------------------------------------------------------------------
Expand Down Expand Up @@ -89,10 +88,6 @@ sheaf(Variety, Matrix) := SheafMap => (X, phi) -> map(sheaf_X target phi,
sheaf(Variety, Matrix, ZZ) := SheafMap => (X, phi, d) -> map(sheaf_X target phi, sheaf_X source phi,
truncate(d, phi, MinimalGenerators => false), d)

-- TODO: remove by M2 1.25
sheafMapWarn = true
sheafMap = x -> (if sheafMapWarn then (sheafMapWarn = false; printerr "Note: sheafMap is deprecated; use sheaf instead."); sheaf x)

random(CoherentSheaf, CoherentSheaf) := SheafMap => o -> (F, G) -> map(F, G, random(F.module, G.module, o))

isWellDefined SheafMap := f -> (
Expand Down
12 changes: 6 additions & 6 deletions M2/Macaulay2/packages/Varieties/doc-functors.m2
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ Node
Hom
HH
sheafExt
yonedaSheafExtension
-- yonedaSheafExtension

Node
Key
Expand Down Expand Up @@ -549,14 +549,14 @@ Node
HH
sheafExt

Node
Key
ExtLongExactSequence
-- Node
-- Key
-- ExtLongExactSequence
-- (ExtLongExactSequence, CoherentSheaf, SheafMap)
-- (ExtLongExactSequence, CoherentSheaf, SheafMap, SheafMap)
-- [ExtLongExactSequence, Concentration]
Headline
the long exact sequence of the Ext functor
-- Headline
-- the long exact sequence of the Ext functor

-----------------------------------------------------------------------------
-- sheafExt
Expand Down
13 changes: 6 additions & 7 deletions M2/Macaulay2/packages/Varieties/doc-maps.m2
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
undocumented {
sheafMap, -- deprecated
-- TODO: document some of these
(symbol SPACE, SheafMap, ZZ),
(symbol +, SheafMap, SheafMap),
Expand Down Expand Up @@ -92,14 +91,14 @@ Node
Headline
induced maps on coherent sheaves

Node
Key
cotangentSurjection
-- Node
-- Key
-- cotangentSurjection
-- (cotangentSurjection, ProjectiveVariety)

Node
Key
embeddedToAbstract
-- Node
-- Key
-- embeddedToAbstract
-- (embeddedToAbstract, ProjectiveVariety)

-----------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion M2/Macaulay2/packages/Varieties/doc-sheaves.m2
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ Node
SeeAlso
idealSheaf
tangentSheaf
cotangentSurjection
-- cotangentSurjection
-- (cotangentSheaf, ZZ, ProjectiveVariety)
ProjectiveVariety

Expand Down
Loading