Made the hardcoded completion field limit configurable #3298
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
只需要添加一种语言 |
Just add a language |
Collaborator
|
Just need to add one language |
Author
|
@sumneko, assuming other languages are kept in sync and markdown files are auto-generated, let me know if there's anything else I need to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm aware that 4.0.0 is being worked on, couldn't find this exact limit there. Haven't seen public statements or ETAs regarding 4.0.0 either. Don't know whether this change will be applied to the version used in Visual Studio Code but I'm doing this under the assumption that it will considering I found this in the master branch.
Basically, I hit the limit (while doing somewhat reasonable stuff) and I guess this would be a good temp fix. I'm assuming changes to locale/setting.lua and doc/config.md are needed, however I'm not sure what I should've done, make a description and translate to all available languages?