Debian build instructions review. #2688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoe
force-pushed
the
debian_nocheck_docs
branch
2 times, most recently
from
904458d to
92b20a7
Compare
smoe
force-pushed
the
debian_nocheck_docs
branch
from
92b20a7 to
0130d17
Compare
petterreinholdtsen
approved these changes
Oct 18, 2023
Collaborator
petterreinholdtsen
left a comment
petterreinholdtsen
left a comment
There was a problem hiding this comment.
Found a few minor issues. The changes seem like a good improvement in general, so I recommend it go in once the minor issues are addressed.
| == Downloading source tree | ||
|
|
||
| The LinuxCNC project git repository is at https://github.com/LinuxCNC/linuxcnc. | ||
| GitHub is a popular git hosting service and code sharing website. |
Collaborator
There was a problem hiding this comment.
Suggest to drop the github explanation. Seem out of place and do not really contribute to the explanation on how to download the source.
Collaborator
There was a problem hiding this comment.
@smoe Do you disagree or just not notice this proposal?
Collaborator
smoe
force-pushed
the
debian_nocheck_docs
branch
from
a77cadd to
f525663
Compare
smoe
force-pushed
the
debian_nocheck_docs
branch
from
f525663 to
d2976a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tend to think that this improves the clarity of the current set of instructions.