Bump the C/C++ language standards version #1953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Did you base this pull request on the wrong branch? Seem to contain commits also in pull request #1278. |
.. this is supported in buster (gcc8) and newer
I believe there is a bug in this component adjacent to this diagnostic, which I've previously reported as LinuxCNC#1943. Silence the warning by giving an explicit initialization to align_pin. This will definitely cause the edge-type carousel to get stuck in the state machine at the point where it waits for the alignment signal. Before this change, one possible undefined behavior was that register and/or the byte(s) of stack corresponding to this local variable would vary unpredictably, leading to the component progressing through the steps of the state machine anyway. However, this should not be relied on.
Collaborator
|
Maybe @andypugh should have a look? I liked what I saw. Sidenote: When there is a sudden abort(), is there any way to have all active movements stopped? |
Contributor
Author
|
I updated this and also pushed it to a branch in linuxcnc/linuxcnc named jepler/bump-gcc-std so we can see how it affects all buildbot target systems |
jepler
changed the title
jepler
changed the title
Contributor
Author
|
This was also 'green' on the buildbot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is cumulative with #1278 and just bumps our C & C++ compiler standards to gnu11 for C files and gnu++17 for C++ files. It should be popped out of draft once that PR Is merged and this one is rebased.
The main reason to consider NOT doing this is that it could lead to accidental inclusion of C language features that are not supported by the kernel's C dialect -- Kernel 5.18 is the first release which also switched to the gnu11 standard. This would affect building for kmod+rtai, something I don't think sees buildbot testing these days anyway.