fix/: change LTOA to LTO10 #529
Conversation
vandelvan
left a comment
vandelvan
left a comment
There was a problem hiding this comment.
Hi @Magic-Kowel
Did you test these changes? could you share the output of your tests please?
There was no need to change the variable and constant names but it's ok as long as you keep it consistent across all files.
Look into the comment I left please.
Thanks!
src/tape_drivers/hp_tape.c
Outdated
| }; | ||
|
|
||
| static struct _timeout_tape timeout_ltoA_hh[] = { | ||
| static struct _timeout_tape timeout_10_hh[] = { |
|
Hello @Magic-Kowel |
src/tape_drivers/tape_drivers.h
Outdated
| DRIVE_LTOA = 0x210A, /* Ultrium Gen A */ | ||
| DRIVE_LTOA_HH = 0x220A, /* Ultrium Gen A Half-High */ | ||
| DRIVE_LTO10 = 0x210A, /* Ultrium Gen A */ | ||
| DRIVE_LTO10_HH = 0x220A, /* Ultrium Gen A Half-High */ |
There was a problem hiding this comment.
Gen 10 also in the comment?
src/tape_drivers/tape_drivers.h
Outdated
| TC_MP_LTO8D_CART = 0x88, /* LTO8 Data cartridge */ | ||
| TC_MP_LTO9D_CART = 0x98, /* LTO9 Data cartridge */ | ||
| TC_MP_LTO10D_CART = 0xA8, /* LTOA Data cartridge */ | ||
| TC_MP_LTOP10D_CART = 0xA9, /* LTOPA Data cartridge */ |
piste-jp
left a comment
piste-jp
left a comment
There was a problem hiding this comment.
I make a few minor comments. It is really great if you accept the changes.
src/tape_drivers/hp_tape.c
Outdated
| }; | ||
|
|
||
| /* Base timeout value for LTO */ | ||
| /* Base timeout value for LTO */ |
There was a problem hiding this comment.
Please remove a space char. It looks inserted accidentally.
juliocelon
left a comment
juliocelon
left a comment
There was a problem hiding this comment.
It looks good to me, thanks, Josué!
This comment was marked as off-topic.
This comment was marked as off-topic.
juliocelon
merged commit 1287159
into
LinearTapeFileSystem:v2.4.8-windows-support
6 participants
LTOA to LTO10
This pull request includes following changes or fixes.
Description
Change LTOA to LTO10
Type of change
Checklist: