Skip to content
This repository was archived by the owner on Jul 15, 2022. It is now read-only.

Conversation

@henri-ly
Copy link
Contributor

@henri-ly henri-ly commented Mar 9, 2022

Context (issues, jira)

https://ledger.slack.com/archives/C02LACPH3U3/p1646834398860669

Description / Usage

missing dependency shouldn't be major because blake it's already on .lock but it's still better to have it on main dependency

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

@henri-ly henri-ly requested a review from a team March 9, 2022 14:11
@vercel
Copy link

vercel bot commented Mar 9, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/DTxZVhX1KWy9v5TqkEasqZVEgkU4
✅ Preview: https://ledger-live-common-git-bugfix-add-blake2b-ledgerhq.vercel.app

Copy link
Contributor

@gre gre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci shows a problem, are you sure there are no diff when running yarn ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants