[8주차] LDH #51
Open
[8주차] LDH #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PandaHun
requested changes
Mar 26, 2021
Member
PandaHun
left a comment
PandaHun
left a comment
There was a problem hiding this comment.
의견 반영 부탁드려요
생각해보고 질문 주셔도 됩니다
8week/racingcar/src/main/java/service/RacingCarGameController.java
Outdated
Show resolved
Hide resolved
8week/racingcar/src/main/java/service/RacingCarGameController.java
Outdated
Show resolved
Hide resolved
8week/racingcar/src/main/java/service/RacingCarGameController.java
Outdated
Show resolved
Hide resolved
PandaHun
requested changes
Apr 6, 2021
Member
PandaHun
left a comment
PandaHun
left a comment
There was a problem hiding this comment.
컨벤션과 네이밍을 주의해주시고
몇몇 궁금증 남겨뒀습니다
| } | ||
|
|
||
| public void movePosition() { | ||
| if (RandomUtils.randomIntGenerator(START_NUMBER, FINISH_NUMBER) > CONTROL_POINT) { |
Member
There was a problem hiding this comment.
이 부분을 매번 생성하는게 아니라
메세지를 보내면 RandomUtils안에서 수행해주면 코드가 더 간결하겠죠?
8week/racingcar/src/main/java/service/RacingCarGameController.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.