More Descriptor Buffer #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaschaWillems
approved these changes
Oct 11, 2025
Collaborator
SaschaWillems
left a comment
SaschaWillems
left a comment
There was a problem hiding this comment.
Great addition. That's some helpful insight :)
gpx1000
approved these changes
Oct 11, 2025
Contributor
gpx1000
left a comment
gpx1000
left a comment
There was a problem hiding this comment.
That's pretty good addition. I never actually realized that but it makes sense that this is the way the descriptor buffers work. I do worry that there should be an explicit "must" somewhere in the spec that the memory is contiguous etc before recommending someone directly memcpy to it. There's also likelihood for security implications somewhere in there as well; but I don't know what those security implications would expose etc.
Anyway, Great information! Definitely worth merging!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more things I realized that I felt should be here