Skip to content

fix normest not working on rectangular matrices #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpo merged 2 commits into from
Apr 11, 2025
Merged

fix normest not working on rectangular matrices #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2210767
fix normest not working on rectangular matrices
njericha Jan 31, 2025
1773afb
Add rectangular matrix tests for normest
njericha Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/utilities.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ function normest(S, tol = -1, maxiter = 100)

x ./= e
e_0 = zero(e)
Sx = zeros(eltype(S), n)
Sx = zeros(eltype(S), m)

while abs(e - e_0) > tol * e
e_0 = e
Expand Down
3 changes: 1 addition & 2 deletions test/test_normest.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ function simple_matrix_test_helper(S, ϵ_norm, ϵ)
end

function simple_matrix_test(ϵ)
(nrow, ncol) = (10, 10)
for (nrow, ncol) in [(10, 10), (5, 5), (3, 3)]
for (nrow, ncol) in [(10, 10), (5, 5), (3, 3), (3, 5), (5, 3), (5, 10), (10, 5)]
ϵ_norm = eps(Float64)
A1 = simple_matrix(ComplexF64, nrow, ncol)
simple_matrix_test_helper(A1, ϵ_norm, ϵ)
Expand Down
Loading