Skip to content

More next item rules refactoring #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 28, 2024
Merged

More next item rules refactoring #75

merged 4 commits into from
Nov 28, 2024

Conversation

@frankier
Copy link
Member

@frankier frankier commented Nov 28, 2024

  • Criteria => MultiCriterion
  • Get rid of most functors and convert into named methods
  • Introduce abstract types for pointwise item criteria

More next item rules refactoring
eb97a2b 
 * Criteria => MultiCriterion
 * Get rid of most functors and convert into named methods
 * Introduce abstract types for pointwise item criteria
@github-actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12076115320

Details

  • 63 of 65 (96.92%) changed or added relevant lines in 13 files are covered.
  • 10 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.2%) to 89.723%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/next_item_rules/prelude/criteria.jl 15 17 88.24%
Files with Coverage Reduction New Missed Lines %
src/CatConfig.jl 1 78.79%
src/next_item_rules/combinators/expectation.jl 1 94.12%
src/next_item_rules/combinators/scalarizers.jl 1 94.12%
src/aggregators/ability_estimator.jl 1 98.11%
src/decision_tree/DecisionTree.jl 1 98.63%
src/next_item_rules/prelude/criteria.jl 1 77.42%
src/Responses.jl 2 92.0%
src/vendor/PushVectors.jl 2 85.19%
Totals Coverage Status
Change from base Build 12071174410: 0.2%
Covered Lines: 777
Relevant Lines: 866
💛 - Coveralls

@frankier frankier marked this pull request as ready for review November 28, 2024 22:50
@frankier frankier merged commit 16feb96 into main Nov 28, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@frankier