Skip to content

Conversation

@pkofod
Copy link
Member

@pkofod pkofod commented Nov 18, 2025

On Mac (Also locally for me on Mac) this one runs for 3200-ish iterations before convergence. I don't. know much about this algorithm and think we should maybe remove it, but that's a different story

#1196

@github-actions
Copy link
Contributor

Benchmark Results (Julia vlts)

Time benchmarks
master 040686f... master / 040686f...
multivariate/solvers/first_order/AdaMax 0.493 ± 0.0051 ms 0.488 ± 0.0051 ms 1.01 ± 0.015
multivariate/solvers/first_order/Adam 0.492 ± 0.0053 ms 0.486 ± 0.0051 ms 1.01 ± 0.015
multivariate/solvers/first_order/BFGS 0.26 ± 0.0051 ms 0.258 ± 0.0056 ms 1.01 ± 0.029
multivariate/solvers/first_order/ConjugateGradient 0.169 ± 0.0027 ms 0.166 ± 0.0032 ms 1.02 ± 0.026
multivariate/solvers/first_order/GradientDescent 1.54 ± 0.01 ms 1.53 ± 0.0073 ms 1 ± 0.0081
multivariate/solvers/first_order/LBFGS 0.228 ± 0.0049 ms 0.226 ± 0.0049 ms 1.01 ± 0.031
multivariate/solvers/first_order/MomentumGradientDescent 2.19 ± 0.017 ms 2.17 ± 0.011 ms 1.01 ± 0.0091
multivariate/solvers/first_order/NGMRES 0.431 ± 0.0075 ms 0.432 ± 0.0069 ms 0.998 ± 0.023
time_to_load 0.384 ± 0.0025 s 0.383 ± 0.0015 s 1 ± 0.0076
Memory benchmarks
master 040686f... master / 040686f...
multivariate/solvers/first_order/AdaMax 0.34 k allocs: 7.16 kB 0.34 k allocs: 7.16 kB 1
multivariate/solvers/first_order/Adam 0.34 k allocs: 7.16 kB 0.34 k allocs: 7.16 kB 1
multivariate/solvers/first_order/BFGS 0.36 k allocs: 15.5 kB 0.36 k allocs: 15.5 kB 1
multivariate/solvers/first_order/ConjugateGradient 0.362 k allocs: 14.2 kB 0.362 k allocs: 14.2 kB 1
multivariate/solvers/first_order/GradientDescent 2.09 k allocs: 0.0759 MB 2.09 k allocs: 0.0759 MB 1
multivariate/solvers/first_order/LBFGS 0.341 k allocs: 14.7 kB 0.341 k allocs: 14.7 kB 1
multivariate/solvers/first_order/MomentumGradientDescent 2.45 k allocs: 0.0818 MB 2.45 k allocs: 0.0818 MB 1
multivariate/solvers/first_order/NGMRES 1.56 k allocs: 0.117 MB 1.56 k allocs: 0.117 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

A plot of the benchmark results has been uploaded as an artifact at .

@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.51%. Comparing base (d41f62c) to head (040686f).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1208      +/-   ##
==========================================
+ Coverage   87.48%   87.51%   +0.02%     
==========================================
  Files          45       45              
  Lines        3517     3517              
==========================================
+ Hits         3077     3078       +1     
+ Misses        440      439       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pkofod pkofod merged commit de9250c into master Nov 18, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants