Skip to content

Conversation

@j-fu
Copy link
Contributor

@j-fu j-fu commented Feb 6, 2025

No description provided.

@termi-official
Copy link
Collaborator

I think this PR requires bumping LinearSolve.jl to v3, because it uses the new API - can you confirm @oscardssmith ?

@oscardssmith
Copy link

confirmed

@j-fu
Copy link
Contributor Author

j-fu commented Mar 17, 2025

In fact it already worked with LinearSolve 2.37 . The switch 2.x -> 3.x was a little bit bumpy on lts, may be there are some users out there who would appreciate to be able to work with 2.x.

@termi-official
Copy link
Collaborator

I see, thanks for clarifying Jürgen. Should we still add the 2.37 as lower compat or at least include some kind of warning when constructing the builder on an old version?

@j-fu
Copy link
Contributor Author

j-fu commented Mar 17, 2025

Ah I did not see that AMG already depends on LinearSolve for the coarse grid solve. The nice thing about the precs API is that it does not need to import anything from LinearSolve.

Under these circumstances, IMHO we should have for compat either "2.37,3" or "2,3". I prefer the former. In the later case, I think those who want to use the precs API already know to ensure to have a sufficiently new LinearSolve, so IMHO we wouldn't need a warning.

@termi-official
Copy link
Collaborator

Yea I introduced LinearSolve directly to give users better, modular control over used the coarse level solver.

@ranjanan ranjanan merged commit 3ae81dc into JuliaLinearAlgebra:master Mar 18, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants