Added a few more tests to improve code coverage #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightswitch05
commented
Oct 25, 2025
| "class": "IN" | ||
| }, | ||
| "answer": [] | ||
| "answer": ["127.0.0.1"] |
Contributor
Author
There was a problem hiding this comment.
Being a non-global address results in the same behavior - but covers more code.
lightswitch05
force-pushed
the
add-more-tests
branch
from
b8d7a4e to
0f1e717
Compare
Owner
|
Thanks!! Just one check is failing now in tests:
|
lightswitch05
force-pushed
the
add-more-tests
branch
from
0f1e717 to
07f2522
Compare
Contributor
Author
|
@JoshData sorry about that - its fixed up now. Since it is a test for an invalid type... I used |
Owner
|
Since this is just in tests that seems totally fine. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see I was woefully late providing updates to #155 and the issue was already addressed. But it seems test were not added. I thought I could maybe help out with a few at least. While I was adding tests, I improve test coverage in a few other spots as well. I think it only bumps the over-all coverage by 1% - but maybe its useful.