Skip to content

Conversation

@JavaSaBr
Copy link
Owner

Move more classes from the network to the model modules

@JavaSaBr JavaSaBr requested a review from crazyrokr November 28, 2025 06:00
@JavaSaBr JavaSaBr self-assigned this Nov 28, 2025
@github-actions
Copy link

Overall Project 85.74% -0.49% 🍏
Files changed 73.26% 🍏

File Coverage
PublishAckMqttInMessage.java 100% 🍏
PublishReceivedMqttInMessage.java 100% 🍏
PublishCompleteMqttInMessage.java 100% 🍏
PublishReleaseMqttInMessage.java 100% 🍏
SingleSubscriber.java 100% 🍏
Subscriber.java 100% 🍏
MqttMessage.java 100% 🍏
SubscribeAckMqtt5OutMessage.java 100% 🍏
UnsubscribeAckMqtt5OutMessage.java 100% 🍏
PendingOutResponseMqttInMessageHandler.java 100% 🍏
SubscribeMqttInMessageHandler.java 100% 🍏
UnsubscribeMqttInMessageHandler.java 100% 🍏
SubscriptionService.java 100% 🍏
ConcurrentSubscriberTree.java 100% 🍏
SubscriberTreeBase.java 100% 🍏
TrackableMqttPublishInMessageHandler.java 100% 🍏
SubscriberNode.java 98.78% 🍏
Publish.java 98.77% 🍏
PublishMqtt311OutMessage.java 97.94% -2.06%
PublishMqttInMessageHandler.java 97.62% 🍏
InMemorySubscriptionService.java 96.59% 🍏
SubscribeMqttInMessage.java 96.3% 🍏
SubscribeAckMqtt311OutMessage.java 96.08% -3.92%
SubscribeMqtt311OutMessage.java 95.92% -4.08%
AuthenticationMqtt5OutMessage.java 95.92% -4.08%
ConnectAckMqtt311OutMessage.java 95.35% -4.65%
DisconnectMqttInMessage.java 94.29% 🍏
UnsubscribeMqttInMessage.java 92.5% 🍏
PersistedMqttPublishOutMessageHandler.java 92% 🍏
SharedSubscriber.java 91.58% 🍏
PublishControlMqttInMessage.java 91.55% 🍏
PublishMqttInMessage.java 91.53% 🍏
UnsubscribeAckMqttInMessage.java 91.01% 🍏
PublishReleaseMqtt311OutMessage.java 89.47% -10.53%
MqttInMessage.java 87.78% 🍏
ConnectMqttInMessage.java 87.76% 🍏
MqttOutMessage.java 87.29% 🍏
PublishCompleteMqtt311OutMessage.java 86.67% -13.33%
PublishAckMqtt311OutMessage.java 86.67% -13.33%
PublishReceivedMqtt311OutMessage.java 86.67% -13.33%
DisconnectMqtt311OutMessage.java 85.71% -14.29%
AbstractMqttClient.java 84.83% -2.76%
AbstractMqttClientReleaseHandler.java 82.73% 🍏
ConnectAckMqttInMessage.java 82.05% 🍏
SubscribeAckMqttInMessage.java 81.61% 🍏
AuthenticationMqttInMessage.java 81.52% 🍏
ConnectInMqttInMessageHandler.java 80.49% 🍏
Qos1MqttPublishInMessageHandler.java 80.45% 🍏
Qos2MqttPublishOutMessageHandler.java 79.41% 🍏
DisconnectMqttInMessageHandler.java 73.58% 🍏
UnsubscribeAckMqtt311OutMessage.java 73.33% -13.33%
InMemoryProcessingPublishes.java 73.23% 🍏
ConnectMqtt311OutMessage.java 71.94% -1.44%
InMemoryMqttNetworkSession.java 68.53% -1.2%
Qos2MqttPublishInMessageHandler.java 65.64% 🍏
AbstractMqttPublishInMessageHandler.java 64.57% 🍏
DefaultConnectionService.java 64.27% -1.73%
Qos1MqttPublishOutMessageHandler.java 63.16% 🍏
AbstractMqttInMessageHandler.java 58.21% -0.36% 🍏
Qos0MqttPublishInMessageHandler.java 51.28% 🍏
InMemoryMqttSessionService.java 46.6% -8.84%
PublishReleaseMqttInMessageHandler.java 40.79% 🍏
MqttNetworkSession.java 0%
PingResponseMqttInMessage.java 0% -15.38%
PingRequestMqttInMessage.java 0% -15.38%
PingResponseMqtt311OutMessage.java 0% -16.67%
PingRequestMqtt311OutMessage.java 0% -16.67%

Array<StringPair> userProperties) implements TrackableMessage {
Array<StringPair> userProperties) {

private static final Array<StringPair> EMPTY_USER_PROPERTIES = Array.empty(StringPair.class);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's moved to MqttMessage interface, doesn't it?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crazyrokr it's not a message :)

@crazyrokr crazyrokr self-requested a review November 28, 2025 18:24
@github-actions
Copy link

Overall Project 85.74% -0.49% 🍏
Files changed 73.26% 🍏

File Coverage
PublishAckMqttInMessage.java 100% 🍏
PublishReceivedMqttInMessage.java 100% 🍏
PublishCompleteMqttInMessage.java 100% 🍏
PublishReleaseMqttInMessage.java 100% 🍏
SingleSubscriber.java 100% 🍏
Subscriber.java 100% 🍏
MqttMessage.java 100% 🍏
SubscribeAckMqtt5OutMessage.java 100% 🍏
UnsubscribeAckMqtt5OutMessage.java 100% 🍏
PendingOutResponseMqttInMessageHandler.java 100% 🍏
SubscribeMqttInMessageHandler.java 100% 🍏
UnsubscribeMqttInMessageHandler.java 100% 🍏
SubscriptionService.java 100% 🍏
ConcurrentSubscriberTree.java 100% 🍏
SubscriberTreeBase.java 100% 🍏
TrackableMqttPublishInMessageHandler.java 100% 🍏
SubscriberNode.java 98.78% 🍏
Publish.java 98.75% 🍏
PublishMqtt311OutMessage.java 97.94% -2.06%
PublishMqttInMessageHandler.java 97.62% 🍏
InMemorySubscriptionService.java 96.59% 🍏
SubscribeMqttInMessage.java 96.3% 🍏
SubscribeAckMqtt311OutMessage.java 96.08% -3.92%
SubscribeMqtt311OutMessage.java 95.92% -4.08%
AuthenticationMqtt5OutMessage.java 95.92% -4.08%
ConnectAckMqtt311OutMessage.java 95.35% -4.65%
DisconnectMqttInMessage.java 94.29% 🍏
UnsubscribeMqttInMessage.java 92.5% 🍏
PersistedMqttPublishOutMessageHandler.java 92% 🍏
SharedSubscriber.java 91.58% 🍏
PublishControlMqttInMessage.java 91.55% 🍏
PublishMqttInMessage.java 91.53% 🍏
UnsubscribeAckMqttInMessage.java 91.01% 🍏
PublishReleaseMqtt311OutMessage.java 89.47% -10.53%
MqttInMessage.java 87.78% 🍏
ConnectMqttInMessage.java 87.76% 🍏
MqttOutMessage.java 87.29% 🍏
PublishCompleteMqtt311OutMessage.java 86.67% -13.33%
PublishAckMqtt311OutMessage.java 86.67% -13.33%
PublishReceivedMqtt311OutMessage.java 86.67% -13.33%
DisconnectMqtt311OutMessage.java 85.71% -14.29%
AbstractMqttClient.java 84.83% -2.76%
AbstractMqttClientReleaseHandler.java 82.73% 🍏
ConnectAckMqttInMessage.java 82.05% 🍏
SubscribeAckMqttInMessage.java 81.61% 🍏
AuthenticationMqttInMessage.java 81.52% 🍏
ConnectInMqttInMessageHandler.java 80.49% 🍏
Qos1MqttPublishInMessageHandler.java 80.45% 🍏
Qos2MqttPublishOutMessageHandler.java 79.41% 🍏
DisconnectMqttInMessageHandler.java 73.58% 🍏
UnsubscribeAckMqtt311OutMessage.java 73.33% -13.33%
InMemoryProcessingPublishes.java 73.23% 🍏
ConnectMqtt311OutMessage.java 71.94% -1.44%
InMemoryMqttNetworkSession.java 68.53% -1.2%
Qos2MqttPublishInMessageHandler.java 65.64% 🍏
AbstractMqttPublishInMessageHandler.java 64.57% 🍏
DefaultConnectionService.java 64.27% -1.73%
Qos1MqttPublishOutMessageHandler.java 63.16% 🍏
AbstractMqttInMessageHandler.java 58.21% -0.36% 🍏
Qos0MqttPublishInMessageHandler.java 51.28% 🍏
InMemoryMqttSessionService.java 46.6% -8.84%
PublishReleaseMqttInMessageHandler.java 40.79% 🍏
MqttNetworkSession.java 0%
PingResponseMqttInMessage.java 0% -15.38%
PingRequestMqttInMessage.java 0% -15.38%
PingResponseMqtt311OutMessage.java 0% -16.67%
PingRequestMqtt311OutMessage.java 0% -16.67%

@JavaSaBr JavaSaBr merged commit 9466c81 into develop Nov 28, 2025
6 checks passed
@JavaSaBr JavaSaBr deleted the move-more-classes-to-from-network-to-model branch November 28, 2025 18:38
@github-actions
Copy link

Overall Project 85.74% -0.49% 🍏
Files changed 73.26% 🍏

File Coverage
PublishAckMqttInMessage.java 100% 🍏
PublishReceivedMqttInMessage.java 100% 🍏
PublishCompleteMqttInMessage.java 100% 🍏
PublishReleaseMqttInMessage.java 100% 🍏
SingleSubscriber.java 100% 🍏
Subscriber.java 100% 🍏
MqttMessage.java 100% 🍏
SubscribeAckMqtt5OutMessage.java 100% 🍏
UnsubscribeAckMqtt5OutMessage.java 100% 🍏
PendingOutResponseMqttInMessageHandler.java 100% 🍏
SubscribeMqttInMessageHandler.java 100% 🍏
UnsubscribeMqttInMessageHandler.java 100% 🍏
SubscriptionService.java 100% 🍏
ConcurrentSubscriberTree.java 100% 🍏
SubscriberTreeBase.java 100% 🍏
TrackableMqttPublishInMessageHandler.java 100% 🍏
SubscriberNode.java 98.78% 🍏
Publish.java 98.75% 🍏
PublishMqtt311OutMessage.java 97.94% -2.06%
PublishMqttInMessageHandler.java 97.62% 🍏
InMemorySubscriptionService.java 96.59% 🍏
SubscribeMqttInMessage.java 96.3% 🍏
SubscribeAckMqtt311OutMessage.java 96.08% -3.92%
SubscribeMqtt311OutMessage.java 95.92% -4.08%
AuthenticationMqtt5OutMessage.java 95.92% -4.08%
ConnectAckMqtt311OutMessage.java 95.35% -4.65%
DisconnectMqttInMessage.java 94.29% 🍏
UnsubscribeMqttInMessage.java 92.5% 🍏
PersistedMqttPublishOutMessageHandler.java 92% 🍏
SharedSubscriber.java 91.58% 🍏
PublishControlMqttInMessage.java 91.55% 🍏
PublishMqttInMessage.java 91.53% 🍏
UnsubscribeAckMqttInMessage.java 91.01% 🍏
PublishReleaseMqtt311OutMessage.java 89.47% -10.53%
MqttInMessage.java 87.78% 🍏
ConnectMqttInMessage.java 87.76% 🍏
MqttOutMessage.java 87.29% 🍏
PublishCompleteMqtt311OutMessage.java 86.67% -13.33%
PublishAckMqtt311OutMessage.java 86.67% -13.33%
PublishReceivedMqtt311OutMessage.java 86.67% -13.33%
DisconnectMqtt311OutMessage.java 85.71% -14.29%
AbstractMqttClient.java 84.83% -2.76%
AbstractMqttClientReleaseHandler.java 82.73% 🍏
ConnectAckMqttInMessage.java 82.05% 🍏
SubscribeAckMqttInMessage.java 81.61% 🍏
AuthenticationMqttInMessage.java 81.52% 🍏
ConnectInMqttInMessageHandler.java 80.49% 🍏
Qos1MqttPublishInMessageHandler.java 80.45% 🍏
Qos2MqttPublishOutMessageHandler.java 79.41% 🍏
DisconnectMqttInMessageHandler.java 73.58% 🍏
UnsubscribeAckMqtt311OutMessage.java 73.33% -13.33%
InMemoryProcessingPublishes.java 73.23% 🍏
ConnectMqtt311OutMessage.java 71.94% -1.44%
InMemoryMqttNetworkSession.java 68.53% -1.2%
Qos2MqttPublishInMessageHandler.java 65.64% 🍏
AbstractMqttPublishInMessageHandler.java 64.57% 🍏
DefaultConnectionService.java 64.27% -1.73%
Qos1MqttPublishOutMessageHandler.java 63.16% 🍏
AbstractMqttInMessageHandler.java 58.21% -0.36% 🍏
Qos0MqttPublishInMessageHandler.java 51.28% 🍏
InMemoryMqttSessionService.java 46.6% -8.84%
PublishReleaseMqttInMessageHandler.java 40.79% 🍏
MqttNetworkSession.java 0%
PingResponseMqttInMessage.java 0% -15.38%
PingRequestMqttInMessage.java 0% -15.38%
PingResponseMqtt311OutMessage.java 0% -16.67%
PingRequestMqtt311OutMessage.java 0% -16.67%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants