Update rest messages, part 1 #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
crazyrokr
requested changes
Nov 27, 2025
network/src/test/groovy/javasabr/mqtt/network/message/out/SubscribeMqtt5OutMessageTest.groovy
Outdated
Show resolved
Hide resolved
| inMessage.exception().message == expectedMessage | ||
| where: | ||
| property | value | expectedMessage | ||
| MqttMessageProperty.WILDCARD_SUBSCRIPTION_AVAILABLE | 2 | MqttProtocolErrors.PROVIDED_INVALID_WILDCARD_SUBSCRIPTION_AVAILABLE |
Collaborator
There was a problem hiding this comment.
I suggest to use on-demand imports in such cases. This makes tests more readable
Owner
Author
There was a problem hiding this comment.
@crazyrokr I prefer to see from which class the constant is
| inMessage.sessionPresent() == sessionPresent | ||
| inMessage.serverReference() == serverReference | ||
| inMessage.reason() == reasonString | ||
| inMessage.assignedClientId() == mqtt311ClientId |
Collaborator
There was a problem hiding this comment.
Could we consider to use the following style in tests?
with(inMessage) {
reasonCode() == ConnectAckReasonCode.NOT_AUTHORIZED
sessionPresent() == sessionPresent
serverReference() == null
reason() == null
assignedClientId() == null
authenticationData() == null
authenticationMethod() == null
responseInformation() == null
maxQos() == null
retainAvailable() == RETAIN_AVAILABLE_IS_NOT_SET
sharedSubscriptionAvailable() == SHARED_SUBSCRIPTION_AVAILABLE_IS_NOT_SET
wildcardSubscriptionAvailable() == WILDCARD_SUBSCRIPTION_AVAILABLE_IS_NOT_SET
subscriptionIdAvailable() == SUBSCRIPTION_IDENTIFIER_AVAILABLE_IS_NOT_SET
maxMessageSize() == MAXIMUM_MESSAGE_SIZE_IS_NOT_SET
serverKeepAlive() == SERVER_KEEP_ALIVE_IS_NOT_SET
sessionExpiryInterval() == SESSION_EXPIRY_INTERVAL_IS_NOT_SET
topicAliasMaxValue() == TOPIC_ALIAS_MAXIMUM_IS_NOT_SET
receiveMaxPublishes() == RECEIVE_MAXIMUM_PUBLISHES_IS_NOT_SET
}
Owner
Author
There was a problem hiding this comment.
will use it for the next tests
|
crazyrokr
approved these changes
Nov 27, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update rest messages to follow MQTT specs.