v10: Improved multi-store usage support #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leProvider` Replaced `FMTCTileProviderSettings.maxStoreLength` with `maxLength` on each store individually Exposed direct constructor for `FMTCTileProvider` Refactored and exposed tile provider logic into seperate `getBytes` method Added more `CacheBehavior` options Added toggle for hit/miss stat recording Added tests Improved documentation
3 tasks
Added internal `_DownloadManagerControlCmd` enum to better describe commands sent to/from the download manager thread (instead of numbers) Refactored download recovery startup to avoid waiting for manager thread to send already known information
Refactored `RootRecovery` singleton instance mangement to be class-internal
…y update when buffer cleared) Improved performance of bulk download thread buffer trackers
Added `StoreReadWriteBehavior` for improved customizability
Deprecated `obscuredQueryParams` Added `urlTransformer` & `urlTransformerOmitKeyValues` [as replacement for above Refactored `_FMTCImageProvider` internals
Added `DebuggingTileBuilder` to example app Fixed bugs
Improved performance of circle tile generation algorithm *Reduced* performance of circle tile count algorithm Improved performance of tile generation algorithms with specified `end`s
…gion.start` & `.end` correctly Fixed bugs in bulk download statistics with `.start` and `.end`
Updated lint set & fixed lints
Documentation improvements Added checks to ensure store exists before attempting to write to it Improved key correctness for image provider Deprecated `FMTCStore.getTileProvider`
Improved documentation Minor example app improvements
… reading whilst browse caching Improved example app capabilities (added ability to explictily disable stores when neccessary)
…ld be incorrectly updated when resolved store set is empty
Minor example app improvements
…p/flutter_map_tile_caching into multi-store-provider
…ic regardless of set limit, meaning store max length was not respected correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on v9, and fully embraces the new many-to-many relationship between tiles and stores to allow for more flexibility when constructing the tile provider.
This allows full & easy support for the ideas in #24 and #83: stores may now be treated as regions if wanted, which allows huge amounts of flexibility and a better UX.
Additionally, vector tiles are now supported in theory, as the internal caching/retrieval logic of the
ImageProviderhas been exposed, although it is out of scope to fully implement support for it.See CHANGELOG for full details.
(fixes #24)
(fixes #83)
(fixes #84)