Enable resetting of SpecialFieldsPreferences #14441
Conversation
- Added private default constructor with default specialFieldsEnabled = true - Added static getDefault() method to create default preferences - Added setAll() method to reset preferences from another instance Fixes JabRef#14409
…erences() - Added getSpecialFieldsPreferences().setAll() call in clear() method - Added getSpecialFieldsPreferencesFromBackingStore() helper method - Added reset handling in importPreferences() method Fixes JabRef#14409
Hey @2400031832!Thank you for contributing to JabRef! Your help is truly appreciated ❤️ We have automated checks in place, based on which you will soon get feedback if any of them are failing. In a while, maintainers will also review your contribution. Once that happens, you can go through their comments in the "Files changed" tab and act on them, or reply to the conversation if you have further inputs. Please re-check our contribution guide in case of any other doubts related to our contribution workflow. |
|
You have removed the "Mandatory Checks" section from your pull request description. Please adhere to our pull request template. |
|
Note that your PR will not be reviewed/accepted until you have gone through the mandatory checks in the description and marked each of them them exactly in the format of |
|
Your code currently does not meet JabRef's code guidelines. IntelliJ auto format covers some cases. There seem to be issues with your code style and autoformat configuration. Please reformat your code (Ctrl+Alt+L) and commit, then push. In special cases, consider using |
|
|
||
| getWorkspacePreferences().setAll(WorkspacePreferences.getDefault()); | ||
| getGuiPreferences().setAll(CoreGuiPreferences.getDefault()); | ||
| getSpecialFieldsPreferences().setAll(SpecialFieldsPreferences.getDefault()); |
There was a problem hiding this comment.
sthgs off with your identation setting
|
Closing PR due to high % of ai usage and changed mandatory checks in PR description (which is also ai generated) |
4 participants
Closes #14409
This PR implements the resetting functionality for
SpecialFieldsPreferencesas described in issue #14400.Changes Made
SpecialFieldsPreferences.java
specialFieldsEnabled = true)getDefault()method to create default preferences instancesetAll()method to reset preferences from another instanceJabRefGuiPreferences.java
getSpecialFieldsPreferences().setAll(SpecialFieldsPreferences.getDefault())call in theclear()methodgetSpecialFieldsPreferencesFromBackingStore()helper methodimportPreferences()methodMandatory Checks