Remove SmartGroup and refactor groups factory #14398

shubhamk0205 · 2025-11-23T21:02:56Z

This PR removes the SmartGroup class and replaces it with ExplicitGroup, as both provided the same functionality. It also resolves an architectural violation by moving the group factory methods from the GUI layer (JabRefSuggestedGroups) into the logic layer (GroupsFactory). Additionally, DefaultGroupsFactory has been renamed to GroupsFactory for improved clarity and naming consistency.

To preserve compatibility, migration logic has been added to ensure that existing .bib files containing serialized SmartGroup entries continue to load correctly and are transparently converted to ExplicitGroup.

Steps to test

Test group creation and functionality
- Open JabRef and create a new library.
- Right-click on the All entries group → Add JabRef suggested groups.
- Verify that:
  - Entries without linked files
  - Entries without groups
    are created successfully.
- Ensure both groups filter entries as expected.
Test backward compatibility
- Open a .bib file containing SmartGroup entries (if available).
- Verify that the groups load correctly and appear in the group tree.
- Confirm that SmartGroup entries are automatically migrated to ExplicitGroup.
Test “Imported Entries” group
- Enable Preferences → Library → Add imported entries to group.
- Import entries using web search, PDF import, or fetchers.
- Check that imported entries appear in the Imported Entries group.
- Confirm the group is an ExplicitGroup.
Test general group operations
- Create, edit, and delete groups.
- Drag and drop groups in the groups tree.
- Ensure all group operations behave normally without regressions.

Mandatory checks

[/] I own the copyright of the code submitted and I license it under the MIT license
[/] I manually tested my changes in running JabRef (always required)
[/] I added JUnit tests for changes (if applicable)
[/] I added screenshots in the PR description (if the change is visible to the user)
[/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if the change is visible to the user)
[/] I checked the user documentation: If documentation needs updates, I opened an issue or submitted a PR to https://github.com/JabRef/user-documentation/

github-actions · 2025-11-23T21:03:09Z

Hey @shubhamk0205!

Thank you for contributing to JabRef! Your help is truly appreciated ❤️

We have automated checks in place, based on which you will soon get feedback if any of them are failing. In a while, maintainers will also review your contribution. Once that happens, you can go through their comments in the "Files changed" tab and act on them, or reply to the conversation if you have further inputs.

Please re-check our contribution guide in case of any other doubts related to our contribution workflow.

…s initialized in every constructor.

Siedlerchr · 2025-11-24T18:54:39Z

jablib/src/test/java/org/jabref/logic/exporter/GroupSerializerTest.java

    }

    @Test
-    void serializeSmartGroup() {


Please also add a test for the migration of the SmartGroup to the new Explicit groups and ideally roundtrip test.
Reading in old format -> Conversion -> Storing in new format

Siedlerchr

add tests for parsing and roundtrip

…groups and added tests for parsing and roundtrip

# Conflicts: # jabgui/src/main/java/org/jabref/gui/externalfiles/ImportHandler.java

…s initialized in every constructor.

…groups and ideally roundtrip test.

…ps, including an ideal roundtrip test (reading in old format -> conversion -> storing in new format). Also added tests for parsing and roundtrip.

shubhamk0205 · 2025-11-26T10:58:35Z

Done with the tests @Siedlerchr

…into fix-for-issue-14143 * 'fix-for-issue-14143' of github.com:shubhamk0205/jabref: Undo changes to KeyCollisionException

…fork/shubhamk0205/fix-for-issue-14143 # Conflicts: # jablib/src/main/java/org/jabref/logic/importer/util/GroupsParser.java

…into fix-for-issue-14143 * 'fix-for-issue-14143' of github.com:shubhamk0205/jabref: Fix name Use _

…fork/shubhamk0205/fix-for-issue-14143

…ue676 * upstream/main: (227 commits) Adapt welcome message (JabRef#14487) Add message when closing a PR Add collection of "all" AI features (JabRef#14438) Trigger conflict-detection on push on main (JabRef#14479) Add unassigned_comment on comment issue New Crowdin updates (JabRef#14483) Tweak labels also at merge conflicts Merge --remove-label and --add-label Remove SmartGroup and refactor groups factory (JabRef#14398) more debug Support html when parsing arXiv identifiers (JabRef#14474) Add debug and fix run Remove "ready-for-review" if changes are required Have label move as last step of comment Add pr number to output change files to file(s) (JabRef#14465) Add CDS archive (JabRef#14476) Fix adapting labels (JabRef#14477) Chore(deps): Bump jablib/src/main/resources/csl-styles (JabRef#14468) Chore(deps): Bump net.bytebuddy:byte-buddy in /versions (JabRef#14472) ...

* upstream/main: (102 commits) Adapt welcome message (JabRef#14487) Add message when closing a PR Add collection of "all" AI features (JabRef#14438) Trigger conflict-detection on push on main (JabRef#14479) Add unassigned_comment on comment issue New Crowdin updates (JabRef#14483) Tweak labels also at merge conflicts Merge --remove-label and --add-label Remove SmartGroup and refactor groups factory (JabRef#14398) more debug Support html when parsing arXiv identifiers (JabRef#14474) Add debug and fix run Remove "ready-for-review" if changes are required Have label move as last step of comment Add pr number to output change files to file(s) (JabRef#14465) Add CDS archive (JabRef#14476) Fix adapting labels (JabRef#14477) Chore(deps): Bump jablib/src/main/resources/csl-styles (JabRef#14468) Chore(deps): Bump net.bytebuddy:byte-buddy in /versions (JabRef#14472) ...

@nonnull

* Remove SmartGroup and refactor groups factory * Removed obsolete SmartGroup localization key & Fixed KeyCollision * Fix the code so the @nonnull field id in KeyCollisionException.java is initialized in every constructor. * added a test for the migraiton of the SmartGroup to the new Explicit groups and added tests for parsing and roundtrip * Remove SmartGroup and refactor groups factory # Conflicts: # jabgui/src/main/java/org/jabref/gui/externalfiles/ImportHandler.java * Removed obsolete SmartGroup localization key & Fixed KeyCollision * Fix the code so the @nonnull field id in KeyCollisionException.java is initialized in every constructor. * added a test for the migration of the SmartGroup to the new Explicit groups and ideally roundtrip test. * fixed format errors * fixed format * fixed importing issue * fixed openwrite by commenting out in rewrite.yml * runned rewriteRun gradel * restoring rewrite.yml * Remove duplicate test * refine comments * Undo changes to KeyCollisionException * usse separator * Fix variable names * Use _ * Fix name * Reduce scope of migration constant and remove superfluous throws * add hint * Fix format * Add `@deprecated` * Fix tests --------- Co-authored-by: Oliver Kopp <kopp.dev@gmail.com> Co-authored-by: Siedlerchr <siedlerkiller@gmail.com> Co-authored-by: Carl Christian Snethlage <calixtus@users.noreply.github.com>

@nonnull

* Remove SmartGroup and refactor groups factory * Removed obsolete SmartGroup localization key & Fixed KeyCollision * Fix the code so the @nonnull field id in KeyCollisionException.java is initialized in every constructor. * added a test for the migraiton of the SmartGroup to the new Explicit groups and added tests for parsing and roundtrip * Remove SmartGroup and refactor groups factory # Conflicts: # jabgui/src/main/java/org/jabref/gui/externalfiles/ImportHandler.java * Removed obsolete SmartGroup localization key & Fixed KeyCollision * Fix the code so the @nonnull field id in KeyCollisionException.java is initialized in every constructor. * added a test for the migration of the SmartGroup to the new Explicit groups and ideally roundtrip test. * fixed format errors * fixed format * fixed importing issue * fixed openwrite by commenting out in rewrite.yml * runned rewriteRun gradel * restoring rewrite.yml * Remove duplicate test * refine comments * Undo changes to KeyCollisionException * usse separator * Fix variable names * Use _ * Fix name * Reduce scope of migration constant and remove superfluous throws * add hint * Fix format * Add `@deprecated` * Fix tests --------- Co-authored-by: Oliver Kopp <kopp.dev@gmail.com> Co-authored-by: Siedlerchr <siedlerkiller@gmail.com> Co-authored-by: Carl Christian Snethlage <calixtus@users.noreply.github.com> # Conflicts: # jabgui/src/main/java/org/jabref/gui/collab/groupchange/GroupChange.java # jabgui/src/main/java/org/jabref/gui/externalfiles/ImportHandler.java # jabgui/src/main/java/org/jabref/gui/groups/GroupNodeViewModel.java # jabgui/src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java # jabgui/src/main/java/org/jabref/migrations/ConvertMarkingToGroups.java # jabgui/src/test/java/org/jabref/migrations/ConvertMarkingToGroupsTest.java # jablib/src/main/java/org/jabref/logic/bibtex/comparator/MetaDataDiff.java # jablib/src/main/java/org/jabref/logic/groups/GroupsFactory.java # jablib/src/main/java/org/jabref/logic/importer/fileformat/BibtexParser.java # jablib/src/main/java/org/jabref/logic/importer/util/GroupsParser.java # jablib/src/main/java/org/jabref/logic/util/MetadataSerializationConfiguration.java # jablib/src/test/java/org/jabref/logic/bibtex/comparator/MetaDataDiffTest.java # jablib/src/test/java/org/jabref/logic/exporter/GroupSerializerTest.java

Remove SmartGroup and refactor groups factory

eea1b37

github-actions bot added the first contrib label Nov 23, 2025

Merge branch 'main' of https://github.com/JabRef/jabref

ad813ad

shubhamk0205 force-pushed the fix-for-issue-14143 branch from 573306d to ad813ad Compare November 23, 2025 21:34

shubhamk0205 added 2 commits November 24, 2025 06:18

Removed obsolete SmartGroup localization key & Fixed KeyCollision

50bdad8

Fix the code so the @nonnull field id in KeyCollisionException.java i…

5aaadc6

…s initialized in every constructor.

Siedlerchr reviewed Nov 24, 2025

View reviewed changes

Siedlerchr requested changes Nov 24, 2025

View reviewed changes

Siedlerchr added the status: changes-required Pull requests that are not yet complete label Nov 24, 2025

shubhamk0205 and others added 2 commits November 26, 2025 02:57

added a test for the migraiton of the SmartGroup to the new Explicit …

5b257a0

…groups and added tests for parsing and roundtrip

Merge branch 'main' into fix-for-issue-14143

67ce491

github-actions bot removed the status: changes-required Pull requests that are not yet complete label Nov 25, 2025

shubhamk0205 added 11 commits November 26, 2025 04:20

Remove SmartGroup and refactor groups factory

84d7c98

# Conflicts: # jabgui/src/main/java/org/jabref/gui/externalfiles/ImportHandler.java

Removed obsolete SmartGroup localization key & Fixed KeyCollision

d8a2d43

Fix the code so the @nonnull field id in KeyCollisionException.java i…

12bff58

…s initialized in every constructor.

added a test for the migration of the SmartGroup to the new Explicit …

67830d7

…groups and ideally roundtrip test.

Added a test for the migration of SmartGroup to the new Explicit grou…

9f851ca

…ps, including an ideal roundtrip test (reading in old format -> conversion -> storing in new format). Also added tests for parsing and roundtrip.

fixed format errors

00a54f8

fixed format

d2141eb

fixed importing issue

50970ab

fixed openwrite by commenting out in rewrite.yml

4024bf0

runned rewriteRun gradel

8720aa9

restoring rewrite.yml

a989e72

koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 26, 2025

Siedlerchr previously approved these changes Nov 30, 2025

View reviewed changes

Remove duplicate test

d881d3d

koppor dismissed Siedlerchr’s stale review via d881d3d November 30, 2025 18:25

refine comments

691d5eb

Siedlerchr and others added 10 commits November 30, 2025 20:05

usse separator

3e8e072

Merge branch 'fix-for-issue-14143' of github.com:shubhamk0205/jabref …

d8802f9

…into fix-for-issue-14143 * 'fix-for-issue-14143' of github.com:shubhamk0205/jabref: Undo changes to KeyCollisionException

Fix variable names

e8094af

Use _

7a9d914

Fix name

e7e23df

Reduce scope of migration constant and remove superfluous throws

fe98c8b

Merge remote-tracking branch 'shubhamk0205/fix-for-issue-14143' into …

d5da74c

…fork/shubhamk0205/fix-for-issue-14143 # Conflicts: # jablib/src/main/java/org/jabref/logic/importer/util/GroupsParser.java

add hint

b8d1cc4

Merge branch 'fix-for-issue-14143' of github.com:shubhamk0205/jabref …

7a62841

…into fix-for-issue-14143 * 'fix-for-issue-14143' of github.com:shubhamk0205/jabref: Fix name Use _

Merge remote-tracking branch 'shubhamk0205/fix-for-issue-14143' into …

9a49033

…fork/shubhamk0205/fix-for-issue-14143

github-actions bot removed the status: changes-required Pull requests that are not yet complete label Nov 30, 2025

koppor added 2 commits November 30, 2025 21:02

Fix format

7568146

Add @deprecated

dfe948f

github-actions bot added the status: changes-required Pull requests that are not yet complete label Nov 30, 2025

koppor previously approved these changes Nov 30, 2025

View reviewed changes

calixtus enabled auto-merge November 30, 2025 20:35

calixtus disabled auto-merge November 30, 2025 20:36

Fix tests

44fc1cb

koppor dismissed their stale review via 44fc1cb November 30, 2025 20:41

koppor approved these changes Nov 30, 2025

View reviewed changes

github-actions bot removed the status: changes-required Pull requests that are not yet complete label Nov 30, 2025

koppor enabled auto-merge November 30, 2025 20:44

koppor added this pull request to the merge queue Nov 30, 2025

Merged via the queue into JabRef:main with commit c178c1e Nov 30, 2025
48 checks passed

github-actions bot mentioned this pull request Nov 30, 2025

Rewrite "Imported Entries" feature #14143

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Remove SmartGroup and refactor groups factory #14398

Remove SmartGroup and refactor groups factory #14398

Uh oh!

shubhamk0205 commented Nov 23, 2025

Uh oh!

github-actions bot commented Nov 23, 2025

Uh oh!

Siedlerchr Nov 24, 2025 •

edited

Loading

Uh oh!

Siedlerchr left a comment

Uh oh!

shubhamk0205 commented Nov 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Remove SmartGroup and refactor groups factory #14398

Remove SmartGroup and refactor groups factory #14398

Uh oh!

Conversation

shubhamk0205 commented Nov 23, 2025

Steps to test

Mandatory checks

Uh oh!

github-actions bot commented Nov 23, 2025

Hey @shubhamk0205!

Uh oh!

Siedlerchr Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Siedlerchr left a comment

Choose a reason for hiding this comment

Uh oh!

shubhamk0205 commented Nov 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Siedlerchr Nov 24, 2025 •

edited

Loading