Skip to content

Conversation

@skeet70
Copy link
Member

@skeet70 skeet70 commented Nov 18, 2025

Sets it back to the old release style. The thing produced by wasm-pack is a ES/nodenext module, but our shim still wraps it into a CJS module, so downstream consumers don't need to change anything. We lose our TS compile checking the validity of dependencies types (though our uses of them are still checked against their declarations). We do this on most (all?) of our other TS projects.

We should probably deprecate 0.7.0, though it did technically work for consumers that had the right mix of bundling voodoo (for ex ironweb's consumption of it worked), it could've been a more breaking change than intended for consumers.

Sets it back to the old release style. The thing produced by wasm-pack
is a ES/nodenext module, but our shim still wraps it into a CJS module,
so downstream consumers don't need to change anything. We lose our TS compile
checking the validity of dependencies types (though our uses of them are still
checked against their declarations). We do this on most (all?) of our other TS projects.
@skeet70 skeet70 requested review from a team as code owners November 18, 2025 03:09
@skeet70 skeet70 requested review from giarc3 and removed request for a team November 18, 2025 03:09
@github-actions
Copy link

github-actions bot commented Nov 18, 2025

File Coverage Lines
All files 0% 0%

Minimum allowed coverage is 24%

Generated by 🐒 cobertura-action against d5aada7

@skeet70 skeet70 merged commit decfd70 into main Nov 18, 2025
8 checks passed
@skeet70 skeet70 deleted the fix-0.7-release branch November 18, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants