Skip to content

kes-agent: allow using the PraosCredentialsAgent constructor #1791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2025
+26 −4
Merged

kes-agent: allow using the PraosCredentialsAgent constructor #1791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions ...sensus-protocol/changelog.d/20251202_104021_georgy.lukyanov_enable_kes_agent.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<!--
A new scriv changelog fragment.

Uncomment the section that is right (remove the HTML comment wrapper).
For top level release notes, leave all the headers commented out.
-->

<!--
### Patch

- A bullet item for the Patch category.

-->
<!--
### Non-Breaking

- A bullet item for the Non-Breaking category.

-->

### Breaking

- Allow `cardano-node` to integrate `kes-agent`: make the `PraosCredentialsAgent` constructor of `PraosCredentialsSource` usable by removing `Void`.
7 changes: 3 additions & 4 deletions ...us-protocol/src/ouroboros-consensus-protocol/Ouroboros/Consensus/Protocol/Praos/Common.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ import qualified Control.Tracer as Tracer
import Data.Function (on)
import Data.Map.Strict (Map)
import Data.Ord (Down (Down))
import Data.Void
import Data.Word (Word64)
import GHC.Generics (Generic)
import NoThunks.Class
Expand Down Expand Up @@ -278,7 +277,7 @@ data PraosCredentialsSource c where
OCert.OCert c -> KES.UnsoundPureSignKeyKES (KES c) -> PraosCredentialsSource c
-- | Connect to a KES agent listening on a service socket at the given path.
PraosCredentialsAgent ::
Agent.DSIGN (ACrypto c) ~ DSIGN => Void -> FilePath -> PraosCredentialsSource c
Agent.DSIGN (ACrypto c) ~ DSIGN => FilePath -> PraosCredentialsSource c

instance (NoThunks (KES.UnsoundPureSignKeyKES (KES c)), Crypto c) => NoThunks (PraosCredentialsSource c) where
wNoThunks ctxt = \case
Expand All @@ -287,7 +286,7 @@ instance (NoThunks (KES.UnsoundPureSignKeyKES (KES c)), Crypto c) => NoThunks (P
[ noThunks ctxt oca
, noThunks ctxt k
]
PraosCredentialsAgent _ fp -> noThunks ctxt fp
PraosCredentialsAgent fp -> noThunks ctxt fp

showTypeOf _ = "PraosCredentialsSource"

Expand All @@ -308,7 +307,7 @@ instantiatePraosCredentials maxKESEvolutions _ (PraosCredentialsUnsound ocert sk
sk
startPeriod
maxKESEvolutions
instantiatePraosCredentials maxKESEvolutions tr (PraosCredentialsAgent _ path) = do
instantiatePraosCredentials maxKESEvolutions tr (PraosCredentialsAgent path) = do
HotKey.mkDynamicHotKey
maxKESEvolutions
(Just $ runKESAgentClient tr path)
Expand Down
Loading