Skip to content

Conversation

@fmaste
Copy link
Contributor

@fmaste fmaste commented Nov 27, 2025

Description

  • When running local clusters with profiling enabled, we increased the wait time before stopping the node to ensure it has sufficient time to dump all profiling data before being terminated.

How make behaved with and without profiling:

Makefile command ./shell.nix project ./nix/workbench/shell.nix ./lib-cabal.sh start-cluster start.sh
make ci-test cardanoNodeProject WB_PROFILING= WB_PROFILING= WB_RTSARGS= cabal_mode=t WB_PROFILING= WB_RTSARGS= -
make ci-test-prof WB_PROFILING must be one of: none, time, ... - - - -
WB_PROFILING=space-heap make ci-test cardanoNodeProject WB_PROFILING=space-heap WB_PROFILING=space-heap WB_RTSARGS= cabal_mode=t WB_PROFILING=space-heap WB_RTSARGS= -
WB_PROFILING=space-heap make ci-test-prof cardanoNodeProject.profiled WB_PROFILING=space-heap WB_PROFILING=space-heap WB_RTSARGS= cabal_mode=t WB_PROFILING=space-heap WB_RTSARGS= -hT -machine-readable -tcardano-node.stats -pocardano-node
make ci-test-nix cardanoNodeProject WB_PROFILING= - cabal_mode= -
make ci-test-profnix WB_PROFILING must be one of: none, time, ... - - - -
WB_PROFILING=space-heap make ci-test-nix cardanoNodeProject WB_PROFILING=space-heap - cabal_mode= -
WB_PROFILING=space-heap make ci-test-profnix cardanoNodeProject.profiled WB_PROFILING=space-heap - cabal_mode= -hT -machine-readable -tcardano-node.stats -pocardano-node

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@fmaste fmaste force-pushed the fmaste/bench-master branch 2 times, most recently from abd1351 to 815801b Compare December 2, 2025 16:08
@fmaste fmaste force-pushed the fmaste/bench-master branch 2 times, most recently from 5a21ac6 to 6883c1b Compare December 5, 2025 02:00
@fmaste fmaste force-pushed the fmaste/bench-master branch 2 times, most recently from b8c82d4 to c5ba59a Compare December 5, 2025 16:13
@fmaste fmaste force-pushed the fmaste/bench-master branch from c5ba59a to 3ca72fa Compare December 5, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants