add pre-commit hooks #142
Merged
add pre-commit hooks #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtavana
requested review from
antonwolfy,
ekomarova,
ndgrigorian and
xaleryb
as code owners
ndgrigorian
reviewed
Mar 31, 2025
Collaborator
ndgrigorian
left a comment
ndgrigorian
left a comment
There was a problem hiding this comment.
Good change! I think it would be good to add a .git-blame-ignore-revs file too, though
ndgrigorian
reviewed
Mar 31, 2025
Collaborator
ndgrigorian
left a comment
ndgrigorian
left a comment
There was a problem hiding this comment.
Also, a workflow for pre-commit would align with the other projects
It would be a good idea to make similar changes in umath and random, as well as the migration to pyproject.toml
Maybe issues should be made for these things
This was referenced Mar 31, 2025
antonwolfy
previously approved these changes
Apr 1, 2025
antonwolfy
reviewed
Apr 1, 2025
antonwolfy
reviewed
Apr 1, 2025
vtavana
force-pushed
the
add-pre-commit
branch
2 times, most recently
from
47513b5 to
5efbeff
Compare
vtavana
force-pushed
the
add-pre-commit
branch
4 times, most recently
from
eed768e to
1bdc21e
Compare
ndgrigorian
reviewed
Apr 1, 2025
ndgrigorian
reviewed
Apr 1, 2025
ndgrigorian
approved these changes
Apr 1, 2025
Collaborator
ndgrigorian
left a comment
ndgrigorian
left a comment
There was a problem hiding this comment.
Nothing more from me, I think this looks good, thanks for your work on this @vtavana
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add pre-commit formatting configuration,
pylinthook is added with "--errors-only" otherwise it suggests a lot of changes which should to be addressed separately, if needed.