update functions name #137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally,
mkl_fft.rfftandmkl_fft.irfftwere replicatingscipy.fftpack.rfftandscipy.fftpack.irfft. However,scipy.fftpackmodule is deprecated and replaced withscipy.fftmodule. And there weremkl_fft.rfft_numpyandmkl_fft.irfft_numpywhich replicatedscipy.fft.rfftandscipy.fft.irfft.In this PR, name of the functions are updated to match with
scipy.fftmodule (andnumpy.fftmodule). This means the following changes are made:mkl_fft.rfftandmkl_fft.irfftare renamed tomkl_fft.rfftpackandmkl_fft.irfftpack, respectively.mkl_fft.rfft_numpy,mkl_fft.irfft_numpy,mkl_fft.rfft2_numpy,mkl_fft.irfft2_numpy,mkl_fft.rfftn_numpyandmkl_fft.irfftn_numpyare renamed tomkl_fft.rfft,mkl_fft.irfft,mkl_fft.rfft2,mkl_fft.irfft2,mkl_fft.rfftnandmkl_fft.irfftn, respectively. (consistent withnumpy.fftandscipy.fftmodules)Also, file
_scipy_fft.pyis renamed to_scipy_fftpack.pysince it replicatesscipy.fftpackmodule (it is not exposed throughmkl_fft.interfaceand is just kept there to be used directly, if needed).In addition, file
_scipy_fft_backend.pyis renamed to_scipy_fft.pysince it replicatesscipy.fftmodule (similar to file_numpy_fft.pywhich replicatesnumpy.fftmodule)