Skip to content

Conversation

@vlad-perevezentsev
Copy link
Contributor

This PR disallows converting non-0D dpnp.ndarray to Python scalars (int, float and complex) and raises TypeError` to align with NumPy 2.4.0

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vlad-perevezentsev
Copy link
Contributor Author

NumPy allows converting non-0D ndarrays to bool and also for __index__ method which contradicts the Python Array API. Should we disallow this as well to comply with the Python Array API?

@github-actions
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2694/index.html

@github-actions
Copy link
Contributor

Array API standard conformance tests for dpnp=0.20.0dev1=py313h509198e_9 ran successfully.
Passed: 1229
Failed: 0
Skipped: 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant