Skip to content

Remove shape=None default in dpnp.reshape #2673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 21, 2025
Merged

Remove shape=None default in dpnp.reshape #2673

merged 11 commits into from
Nov 21, 2025

Conversation

@vlad-perevezentsev
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev commented Nov 17, 2025

This PR updates the signature of dpnp.reshape by removing None default value for shape argument
and requiring it to be passed explicitly according to Python array API

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vlad-perevezentsev vlad-perevezentsev added this to the 0.20.0 release milestone Nov 17, 2025
@vlad-perevezentsev vlad-perevezentsev self-assigned this Nov 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy reviewed Nov 17, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.20.0dev1=py313h509198e_12 ran successfully.
Passed: 1229
Failed: 0
Skipped: 7

antonwolfy
antonwolfy approved these changes Nov 18, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vlad-perevezentsev

Base automatically changed from remove_newshape to master November 18, 2025 12:19
@coveralls
Copy link
Collaborator

coveralls commented Nov 19, 2025

Coverage Status

coverage: 81.45% (+0.003%) from 81.447%
when pulling 56331e2 on require_shape_in_reshape
into 131c490 on master.

@vlad-perevezentsev vlad-perevezentsev merged commit d99fa65 into master Nov 21, 2025
89 of 93 checks passed
@vlad-perevezentsev vlad-perevezentsev deleted the require_shape_in_reshape branch November 21, 2025 10:02
github-actions bot added a commit that referenced this pull request Nov 21, 2025
@github-actions
Remove shape=None default in dpnp.reshape (#2673)
f67fd2c 
This PR updates the signature of `dpnp.reshape` by removing `None`
default value for `shape` argument
and requiring it to be passed explicitly according to [Python array API
](https://data-apis.org/array-api/draft/API_specification/generated/array_api.reshape.html#reshape) d99fa65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels

None yet

Projects

None yet

Milestone

0.20.0 release

Development

Successfully merging this pull request may close these issues.

3 participants

@vlad-perevezentsev @coveralls @antonwolfy