-
Notifications
You must be signed in to change notification settings - Fork 23
Redesigned dpnp.modf function to be a part of ufunc and vm pybind11 extensions
#2654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
antonwolfy
wants to merge
13
commits into
master
Choose a base branch
from
impl-modf
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpnp.modf as part of pybind11 extension ufuncdpnp.modf as part of ufunc extension
Collaborator
…th two output arrays
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2654/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.20.0dev0=py313h509198e_46 ran successfully. |
dpnp.modf as part of ufunc extension dpnp.modf function to be a part of ufunc and vm pybind11 extensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR updates implementation of
dpnp.modfto move it from old legacy backend to be part ofufuncandvmextensions.Also
DPNPUnaryTwoOutputsFuncclass is extended with support of oneMKL VM functions.The tests for unary functions with 2 output arrays are separated to
dpnp/tests/test_unary_two_outputs_ufuncs.pyfile.And the legacy implementation of
dpnp.modfwas cleaned up.