-
Notifications
You must be signed in to change notification settings - Fork 23
Remove wildcard imports in dpnp.fft and dpnp.random submodules
#2649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2649/index.html |
|
Array API standard conformance tests for dpnp=0.20.0dev0=py313h509198e_44 ran successfully. |
dpnp.fft and dpnp.random submodules
7e4c6ad to
8afa380
Compare
|
|
||
| from dpnp.fft.dpnp_iface_fft import * | ||
| from dpnp.fft.dpnp_iface_fft import __all__ as __all__fft | ||
| from .dpnp_iface_fft import __all__ as __all__fft |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need __all__ in dpnp/fft/dpnp_iface_fft.py then?
Can we move it here?
This PR proposes to remove wildcard imports from
dpnp.fftanddpnp.randomsubmodules and register them as explicit submodules indpnpnamespace.It also removes wildcard import of
dpnp.memoryfromdpnp_iface.py