Skip to content

Conversation

@vlad-perevezentsev
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev commented Nov 4, 2025

This PR proposes to remove wildcard imports from dpnp.fft and dpnp.random submodules and register them as explicit submodules in dpnp namespace.

It also removes wildcard import of dpnp.memory from dpnp_iface.py

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Nov 4, 2025
@vlad-perevezentsev vlad-perevezentsev changed the title Remove wildcard import Remove wildcard imports Nov 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

View rendered docs @ https://intelpython.github.io/dpnp/pull/2649/index.html

@coveralls
Copy link
Collaborator

coveralls commented Nov 4, 2025

Coverage Status

coverage: 81.4% (-0.001%) from 81.401%
when pulling 8afa380 on remove_wildcard_import
into c9afa82 on master.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

Array API standard conformance tests for dpnp=0.20.0dev0=py313h509198e_44 ran successfully.
Passed: 1229
Failed: 0
Skipped: 7

@antonwolfy antonwolfy added this to the 0.20.0 release milestone Nov 8, 2025
@vlad-perevezentsev vlad-perevezentsev changed the title Remove wildcard imports Remove wildcard imports in dpnp.fft and dpnp.random submodules Nov 11, 2025
@vlad-perevezentsev vlad-perevezentsev marked this pull request as ready for review November 11, 2025 14:14

from dpnp.fft.dpnp_iface_fft import *
from dpnp.fft.dpnp_iface_fft import __all__ as __all__fft
from .dpnp_iface_fft import __all__ as __all__fft
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need __all__ in dpnp/fft/dpnp_iface_fft.py then?
Can we move it here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants