Skip to content

Conversation

@christopherngutierrez
Copy link
Contributor

Proposed changes

  • Adds Relin, Rotate, and Rescale kernels to Kerngraph
  • Adds support for comments that indicate portions of the kernel that is loop reorderable, e.g. Comment("<reorderable>") and Comment("</reorderable>").
  • Added reorderable tags to DigitDecomp and Mod kernels. Implicitly supported in Relin/Rotate.
  • Adds a "tmp" labels to KeyMul and DigitDecomp to avoid naming collisions.
  • Adds new command line argument --optimal to kerngraph. If passed, the code will read a configuration file for optimal loop ordering. Currently only supports for one loop order for all reorderable sections of the code.
  • Verified on local configuration

Types of changes

What types of changes does your code introduce to the Encrypted Computing SDK project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you are unsure about any of them, do not hesitate to ask. We are
here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING agreement
  • Current formatting and unit tests / base functionality passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

NA

Copy link
Contributor

@joserochh joserochh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests run locally.

Copy link
Collaborator

@kylanerace kylanerace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, actively used

@christopherngutierrez christopherngutierrez merged commit 8dfbe7f into main Nov 6, 2025
7 checks passed
@christopherngutierrez christopherngutierrez deleted the christopherngutierrez/kerngraph-tagged-loop-reordering branch November 6, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants