Skip to content

fix: Proper colossal pouch maxDegradedCapacity at lower RC levels (#55) #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Infinitay wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Proper colossal pouch maxDegradedCapacity at lower RC levels (#55) #56

Infinitay wants to merge 2 commits into from

Conversation

@Infinitay
Copy link
Owner

@Infinitay Infinitay commented Nov 21, 2024 •
edited
Loading

EssencePouch

  • Fixed incorrect degraded values within updateMaxDegradedCapacity for colossal pouches at a lower Runecrafting level (<85)

@Infinitay
fix: Proper colossal pouch maxDegradedCapacity at lower RC levels (#55)
a95a17c
@Infinitay
fix: inventory state and revert remaining essence after pouch degrades
ca0d49e 
- EssencePouch#createPouch sets degraded pouch remainingEssenceBeforeDecay to 0
- Fixed incorrect inventory state after pouch degrade and inventory update handled
- Revert `remainingEssenceBeforeDecay` for pouches in EssencePouchTrackingPlugin#handPouchActionsPostDegrade
@Infinitay
Copy link
Owner Author

Infinitay commented Nov 23, 2024 •
edited
Loading

ca0d49e

EssencePouches

  • When creating an EssencePouch via #createPouch, set the remaining essence before decay to 0 instead of Integer.MIN_VALUE

EssencePouchTrackingPlugin

  • Fix the inventory state being incorrect after a pouch has degraded and the state successfully handled/updated
    • In cases where the user performs one fill pouch action, the inventory state was being updated and therefore when the #handPouchActionsPostDegrade was ran and it did the opposite, it caused rollover issues due to the wrong inventory state
  • Revert a pouch's remainingEssenceBeforeDecay within #handPouchActionsPostDegrade when performing opposite actions

@Infinitay Infinitay mentioned this pull request Nov 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Infinitay