Improve iterators and restore outputlevel #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
==========================================
+ Coverage 68.53% 68.54% +0.01%
==========================================
Files 81 81
Lines 4023 4031 +8
==========================================
+ Hits 2757 2763 +6
- Misses 1266 1268 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a handful of improvements to the updated solvers codes:
AbstractNetworkIteratortypes not executing their onlycompute!call. #262) and fixinglengthfor SweepIteratoroutputleveladded back toeigsolveandapplyexpnsiteskeyword is no longer required to construct a SweepIterator (was accidentally required by not providing a default inregion_plans/euler_plans.jl.This PR supersedes #262 by including all changes from it.