-
Notifications
You must be signed in to change notification settings - Fork 47
Parameter ensemble plot #1574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
plakrisenko
wants to merge
10
commits into
develop
Choose a base branch
from
parameter_ensemble_plot
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Parameter ensemble plot #1574
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
42c629a
add ensemble parameters plot
plakrisenko 61ace8b
change colors
plakrisenko 9195e4f
Merge branch 'develop' into parameter_ensemble_plot
plakrisenko da99c3b
add possibility to plot a subset of parameters
plakrisenko a4d9dd9
change to vertical
plakrisenko f5691c9
fix white spaces
plakrisenko 0faa1b1
Merge branch 'develop' into parameter_ensemble_plot
plakrisenko f8f72b1
Merge branch 'develop' into parameter_ensemble_plot
vwiela 7d26267
Merge branch 'develop' into parameter_ensemble_plot
dweindl 8307336
Merge branch 'develop' into parameter_ensemble_plot
plakrisenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -646,6 +646,22 @@ def test_ensemble_identifiability(): | |
| # test plotting from a collection object | ||
| visualize.ensemble_identifiability(my_ensemble) | ||
|
|
||
| @close_fig | ||
| def test_ensemble_parameters_plot(): | ||
| # creates a test problem | ||
| problem = create_problem(n_parameters=100) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. such a big one necessary for the test? 🙈 |
||
|
|
||
| my_ensemble = [ | ||
| (1 + np.cos(ix) ** 2) * np.random.rand(500) - 1.0 + np.sin(ix) | ||
| for ix in range(100) | ||
| ] | ||
| my_ensemble = ensemble.Ensemble( | ||
| np.array(my_ensemble), lower_bound=problem.lb, upper_bound=problem.ub | ||
| ) | ||
|
|
||
| visualize.ensemble_parameters_plot(my_ensemble) | ||
| visualize.ensemble_parameters_plot(my_ensemble, parameter_ids=[0,5,8,13,17,33,45,76,82,88,90]) | ||
|
|
||
|
|
||
| @close_fig | ||
| def test_profiles(): | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is a method to generally just visualize the ensemble, so we cannot really say that the rectangles represent, for example, 95% confidence intervals. But one would need to create an ensemble in some way, and then subset it using a xi^2 threshold to get confidence intervals, right?
Would it be good to have this showcased somewhere, like in a notebook that mentiones ensembles or identifiability? How to use this visualization correctly? Or is it ok to just expand the description of the visualization in the docstring to describe that it will just visualize all members of the ensemble and that these do not represent CIs.