Ilias_Khugaev-w2-Databases #13

Narpimers · 2025-05-28T12:55:00Z

No description provided.

yunchen4

Hey Ilias,

There is a big point that you need to think again and rework. It's about the relationship between authors and papers. Is it one-to-one, one-to-many, or many-to-many?
Please let me know on Slack when you finish the rework. Don't hesitate to contact me if you have any questions!

yunchen4 · 2025-06-01T11:30:50Z

Week2/assignment/Keys.js

+    CREATE TABLE IF NOT EXISTS authors (
+        author_id INT AUTO_INCREMENT PRIMARY KEY,
+        author_name VARCHAR(50) NOT NULL,
+        university TEXT,


suggestion: TEXT is for long text. VARCHAR should be enough for university name.

yunchen4 · 2025-06-01T11:33:09Z

Week2/assignment/Keys.js

+        university TEXT,
+        date_of_birth DATE NOT NULL,
+        h_index INT NOT NULL,
+        paper_id INT,


Need rework: if an author write several papers, is paper_id a good idea to have in the author table?

You can re-think about the relationship between papers and authors.

Narpimers · 2025-06-05T14:54:36Z

@yunchen4 Thank you for your feedback! I’ve made changes based on your suggestions and added an additional join table between authors and papers. I hope this is a good solution for handling cases where one author has multiple research publications.

yunchen4

Hi Ilias,

Your new table schema is correct. However you also need to change your solutions for aggregating functions to use the new relationship table. I have made them explicit.
Please let me know if you have any questions!

yunchen4 · 2025-06-06T18:44:35Z

Week2/assignment/Relationships.js

+        paper_id INT AUTO_INCREMENT PRIMARY KEY,
+        paper_title VARCHAR(100) NOT NULL,
+        conference TEXT,
+        author_id INT,


Since you have a new table for the relationship between authors and papers, you don't need author_id column in paper table, as one paper can be written by several authors.

yunchen4 · 2025-06-06T18:45:34Z

Week2/assignment/Joins.js

+
+export const joins = async() => {
+    connection.query("SELECT author_name, mentor FROM authors");
+    connection.query("SELECT authors.author_name, research_papers.paper_title FROM authors LEFT JOIN research_papers ON authors.author_id =  research_papers. author_id");


Needs rework: what if a paper has several different authors? You should use the relationship table.

yunchen4 · 2025-06-06T18:47:05Z

Week2/assignment/Aggregate-Functions.js

+
+
+export const aggreg = async() => {
+    connection.query("SELECT paper_title, COUNT(author_id) AS author_count FROM  research_papers GROUP BY paper_title");


Needs rework: based on the current table schema, you always get one author per paper, as author_id in paper table accepts only one int. You need to use the relationship table.

yunchen4 · 2025-06-06T18:49:44Z

Week2/assignment/Aggregate-Functions.js

+    connection.query("SELECT paper_title, COUNT(author_id) AS author_count FROM  research_papers GROUP BY paper_title");
+    connection.query("SELECT COUNT(research_papers.paper_id) FROM research_papers INNER JOIN authors on authors.author_id = research_papers.author_id  WHERE authors.gender = 'female'");
+    connection.query("SELECT university,  FROM authors GROUP BY university");
+    connection.query("SELECT university, COUNT(paper_id) FROM authors GROUP BY university");


connection.query("SELECT university, COUNT(paper_id) FROM authors GROUP BY university");
Needs rework: you have changed your table schemas to have the relationship table, and there's no paper_id column in authors. So you have to write this query using the relationship table. And be careful: what if several authors from the same university are writing the same paper? Will the same paper be counted multiple times?

yunchen4 · 2025-06-06T18:51:02Z

Week2/assignment/Aggregate-Functions.js

+
+export const aggreg = async() => {
+    connection.query("SELECT paper_title, COUNT(author_id) AS author_count FROM  research_papers GROUP BY paper_title");
+    connection.query("SELECT COUNT(research_papers.paper_id) FROM research_papers INNER JOIN authors on authors.author_id = research_papers.author_id  WHERE authors.gender = 'female'");


connection.query("SELECT COUNT(research_papers.paper_id) FROM research_papers INNER JOIN authors on authors.author_id = research_papers.author_id WHERE authors.gender = 'female'");
Needs rework: same here, you need to use the relationship table. And be careful: what if several female authors are writing the same paper? Will the same paper be counted multiple times?

yunchen4 · 2025-06-06T18:53:07Z

Week2/assignment/Relationships.js

+export const relationships = async() => {
+


I saw you export those functions but I didn't see you use them?

yunchen4

Hi Ilias,
I left some comments for the aggregate problems. Overall you're doing them correctly, but there are some points you need to check again and be aware of.
I will approve your PR.

yunchen4 · 2025-06-13T18:44:55Z

Week2/assignment/Aggregate-Functions.js

+
+export const aggreg = async() => {
+    connection.query("SELECT rp.paper_id,rp.paper_title, COUNT(ap.author_id) AS number_of_authors FROM   research_papers rp LEFT JOIN  author_papers ap ON rp.paper_id = ap.paper_id GROUP BY   rp.paper_id, rp.paper_title");
+    connection.query("SELECT COUNT(ap.paper_id) AS total_papers_by_female_authors FROM  authors a JOIN author_papers ap ON a.author_id = ap.author_id  a.gender = 'female';");


Please notice this query has syntax error: "SELECT COUNT(ap.paper_id) AS total_papers_by_female_authors FROM authors a JOIN author_papers ap ON a.author_id = ap.author_id a.gender = 'female';"

You're missing where.

And notice that you will count the same paper for multiple times if several female authors write this paper. If you don't want to count duplicated paper, you need to use DISTINCT.

yunchen4 · 2025-06-13T18:45:25Z

Week2/assignment/Aggregate-Functions.js

+    connection.query("SELECT rp.paper_id,rp.paper_title, COUNT(ap.author_id) AS number_of_authors FROM   research_papers rp LEFT JOIN  author_papers ap ON rp.paper_id = ap.paper_id GROUP BY   rp.paper_id, rp.paper_title");
+    connection.query("SELECT COUNT(ap.paper_id) AS total_papers_by_female_authors FROM  authors a JOIN author_papers ap ON a.author_id = ap.author_id  a.gender = 'female';");
+    connection.query("SELECT AVG(h_index) AS avg_h_index FROM authors GROUP BY university");
+    connection.query("SELECT a.university, COUNT(ap.paper_id) AS total_papers FROM authors a JOIN author_papers ap ON a.author_id = ap.author_id GROUP BY a.university");


Same here, if several authors from the same university write the same paper, this paper will be counted multiple times.

Finished assgignment

7d05c71

yunchen4 self-assigned this May 29, 2025

yunchen4 added the To review label May 29, 2025

yunchen4 requested changes Jun 1, 2025

View reviewed changes

yunchen4 added Needs work and removed To review labels Jun 1, 2025

finale commit

e9b7344

yunchen4 requested changes Jun 6, 2025

View reviewed changes

fixed aggr

4e86358

yunchen4 approved these changes Jun 13, 2025

View reviewed changes

yunchen4 added Approved and removed Needs work labels Jun 13, 2025



		export const aggreg = async() => {
		connection.query("SELECT paper_title, COUNT(author_id) AS author_count FROM research_papers GROUP BY paper_title");

Ilias_Khugaev-w2-Databases #13

Are you sure you want to change the base?

Ilias_Khugaev-w2-Databases #13

Uh oh!

Conversation

Narpimers commented May 28, 2025

Uh oh!

yunchen4 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Narpimers commented Jun 5, 2025

Uh oh!

yunchen4 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yunchen4 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants