Igor w4 databases #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunchen4
approved these changes
Sep 19, 2025
yunchen4
left a comment
yunchen4
left a comment
There was a problem hiding this comment.
LGTM, only a small suggestion to improve performance.
Comment on lines
+86
to
+98
| try { | ||
| // Test total population for Netherlands | ||
| const countryResult = await getTotalPopulationByCountry('Netherlands'); | ||
| console.log('Total Population for Netherlands:'); | ||
| console.log(JSON.stringify(countryResult, null, 2)); | ||
|
|
||
| // Test continent data for Year 2020, Age 100+ | ||
| const continentResult = await getContinentDataByYearAndAge(2020, '100+'); | ||
| console.log('\nContinent Data for Year 2020, Age 100+:'); | ||
| console.log(JSON.stringify(continentResult, null, 2)); | ||
| } catch (err) { | ||
| console.error('Error in main:', err); | ||
| } |
There was a problem hiding this comment.
Suggestion: Since you will call both functions in this function, you can move DB client initialization and closing in the main rather than in each function. This can reduce the overhead of initializing and closing DB connections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.