Skip to content

Conversation

@jbrichau
Copy link
Member

Time to sync up again ;-)

Johan Brichau and others added 28 commits August 19, 2024 18:39
…utAll:startingAt: since it is now included in Grease-Core
…y as argument since this method is used in Seaside with any String or ByteArray
Expanded the testcase for GRPlatform>>secureHashFor:
- remove classCommentOf:, part of swagger
- remove GRWorkingWriteStream, no need
- add pad* methods
- no longer support Squeak 5.3
- rename Pharo classes to Squeak
- add PackageManifest class
List all platforms grease can be run on
Identifying on which platform is Grease running
@dalehenrich
Copy link
Member

@jbrichau, the github CI jobs were not run for this PR (for some reason) and when I looked at the incoming ci.yml and the existing ci.yml it looked like I at least the existing ci.yml needed to be updated so, I ended up modifying the ci.yml on the master branch and got it to pass (without conflicting with your incoming ci.yml) ... now I think that if you merge the latest GsDevKit/Grease:master into your SeasideSt/gsdevkit-merge branch, the CI job should run and pass ...

If that won't work for you for some reason, then I will go ahead and merge the pull request as is and if we don't get another CI job run, I'll force one :)

I'm not quite sure why the CI jobs don't always run for pull requests and I don't know of a way to force them to run, if they were skipped ...

Oh well :)

@jbrichau
Copy link
Member Author

jbrichau commented Dec 2, 2025

Hey @dalehenrich
It ran: https://github.com/GsDevKit/Grease/actions/runs/19868004589
But it's red because of the Slack posting. Probably some keys are missing...
Looks like these environment vars are missing?
Error: Error: Input required and not supplied: slack_webhook_url

@dalehenrich
Copy link
Member

No problem ... I'll go ahead and merge the pull request and then debug CI job ... later today ...

@dalehenrich dalehenrich merged commit dcad886 into GsDevKit:master Dec 2, 2025
11 of 13 checks passed
@dalehenrich
Copy link
Member

Yep, CI job ran fine after merge! Thanks for the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants