-
Notifications
You must be signed in to change notification settings - Fork 0
Sync with Grease master #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… since it is not only required in Pharo (see GsDevKit#33)
…utAll:startingAt: since it is now included in Grease-Core
…y as argument since this method is used in Seaside with any String or ByteArray
Expanded the testcase for GRPlatform>>secureHashFor:
- remove classCommentOf:, part of swagger - remove GRWorkingWriteStream, no need - add pad* methods
Camp 2025 Squeak fixes round 1
- no longer support Squeak 5.3 - rename Pharo classes to Squeak - add PackageManifest class
Squeak fixes camp 2025 2
Url and typo
List all platforms grease can be run on
Identifying on which platform is Grease running
|
@jbrichau, the github CI jobs were not run for this PR (for some reason) and when I looked at the incoming ci.yml and the existing ci.yml it looked like I at least the existing ci.yml needed to be updated so, I ended up modifying the ci.yml on the master branch and got it to pass (without conflicting with your incoming ci.yml) ... now I think that if you merge the latest GsDevKit/Grease:master into your SeasideSt/gsdevkit-merge branch, the CI job should run and pass ... If that won't work for you for some reason, then I will go ahead and merge the pull request as is and if we don't get another CI job run, I'll force one :) I'm not quite sure why the CI jobs don't always run for pull requests and I don't know of a way to force them to run, if they were skipped ... Oh well :) |
|
Hey @dalehenrich |
|
No problem ... I'll go ahead and merge the pull request and then debug CI job ... later today ... |
|
Yep, CI job ran fine after merge! Thanks for the update |
Time to sync up again ;-)