Fix localgrid grabbing #3527
Open
Fix localgrid grabbing #3527
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0HyperCube
reviewed
Dec 24, 2025
Comment on lines
568
to
578
| let viewport_delta = input.mouse.position - self.mouse_position; | ||
| let document_space_transform = self.initial_transform * document_to_viewport.inverse(); | ||
| let delta_pos = if self.state.is_transforming_in_local_space { | ||
| let [local_x_axis, local_y_axis] = self.state.local_transform_axes; | ||
| let local_components = DVec2::new(viewport_delta.dot(local_x_axis), viewport_delta.dot(local_y_axis)); | ||
| document_space_transform.matrix2 * local_components | ||
| } else { | ||
| document_space_transform.transform_vector2(viewport_delta) | ||
| }; | ||
| let scale = document_to_viewport.y_axis.length(); | ||
| let delta_scaled = (if self.slow { delta_pos / SLOWING_DIVISOR } else { delta_pos }) / scale; |
Contributor
There was a problem hiding this comment.
Along with adding significant complexity here, you have also broken the «local x-axis constraint» feature (press G to grab then press X twice.
broken_local_grab.mp4
I don't see why there should be any changes to the functionality of the system, since the issue concerned only changing the overlays.
Contributor
Author
There was a problem hiding this comment.
letme try this again
Contributor
Author
|
this solved the constraint breakage but now every scale is getting calculated with reference to global axis only |
Contributor
The scale by pressing key S then X will scale in viewport space. Pressing X again will scale in local space. This is the intended behaviour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the global state showcase when grabbed even after rotating with an angle
code todo - https://discord.com/channels/731730685944922173/881073965047636018/1399533117441835080
Screen.Recording.2025-12-24.at.6.13.43.AM.1.mov
@Keavon kindly review this
didnt got the issue no.