Skip to content

Conversation

@anshukaira
Copy link
Member

@anshukaira anshukaira commented Nov 11, 2025

Making Cloud Functions ADC Compliant

  • Updated Makefile
  • Added metadata.yaml and metadata.display.yaml files
  • Updated python version for fixing build run in tests

@anshukaira anshukaira requested review from a team and prabhu34 as code owners November 11, 2025 13:13
@anshukaira anshukaira force-pushed the adc-compliance branch 6 times, most recently from 7108ad5 to 0467c6e Compare November 11, 2025 15:13
@apeabody
Copy link
Contributor

Thanks! After this PR is merged, you will want to open a PR to add:

      lint_env = {
        ENABLE_BPMETADATA = "1"
      }

at https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/blob/b0c6241ea40cd940b153aa3c1e64b53711b4fde0/infra/terraform/test-org/org/locals.tf#L667

type = string
}

variable "function_location" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be marked as a "fix" so it will trigger a release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, i will update the PR and commit message, lmk in case anything else is required as well

@anshukaira
Copy link
Member Author

Thanks! After this PR is merged, you will want to open a PR to add:

      lint_env = {
        ENABLE_BPMETADATA = "1"
      }

at https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/blob/b0c6241ea40cd940b153aa3c1e64b53711b4fde0/infra/terraform/test-org/org/locals.tf#L667

Created a PR
GoogleCloudPlatform/cloud-foundation-toolkit#3266

@anshukaira anshukaira changed the title chore: Making Cloud Functions ADC Compliant fix: Making Cloud Functions ADC Compliant Nov 12, 2025
@anshukaira anshukaira force-pushed the adc-compliance branch 8 times, most recently from 2bd5ac1 to ffdebf5 Compare November 14, 2025 06:14
@prabhu34
Copy link
Collaborator

@apeabody Need your help here. The builds fail with different errors each time w.r.t to the secure functions modules. Are you aware of the modules being used by any teams?

@amandakarina Can you help here as well ?

@apeabody
Copy link
Contributor

@apeabody Need your help here. The builds fail with different errors each time w.r.t to the secure functions modules. Are you aware of the modules being used by any teams?

@amandakarina Can you help here as well ?

Hi @prabhu34 - Unfortunately I'm not familiar, but the current build failed due to:

  • the Compute Engine API not being enabled in time.
  • an project naming conflict.

For the later, assuming it's a random conflict, I recommend adding: random_project_id_length = 4 to the project factory module defintion as it implements a larger collusion domain than the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants