-
Notifications
You must be signed in to change notification settings - Fork 38
fix: Making Cloud Functions ADC Compliant #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
7108ad5 to
0467c6e
Compare
|
Thanks! After this PR is merged, you will want to open a PR to add: |
| type = string | ||
| } | ||
|
|
||
| variable "function_location" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change should be marked as a "fix" so it will trigger a release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, i will update the PR and commit message, lmk in case anything else is required as well
Created a PR |
0467c6e to
c0b22f9
Compare
2bd5ac1 to
ffdebf5
Compare
ffdebf5 to
90d39f1
Compare
90d39f1 to
90c9629
Compare
|
@apeabody Need your help here. The builds fail with different errors each time w.r.t to the secure functions modules. Are you aware of the modules being used by any teams? @amandakarina Can you help here as well ? |
Hi @prabhu34 - Unfortunately I'm not familiar, but the current build failed due to:
For the later, assuming it's a random conflict, I recommend adding: |
Making Cloud Functions ADC Compliant