Add NoRedundantTraitUseRule to detect nested traits #906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port the rule from phpstan-strict-rules PR #279 to detect when a class uses both a trait A and trait B, where trait A already uses trait B. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
AronNovak
changed the title
Member
Author
|
I tried to do a generic contribution at: No luck. |
Analyzed trait dependency hierarchies and removed 39 redundant trait imports across: - RoboFile.php: Removed DeploymentTrait (included via ImportToUi) - EntityViewBuilder classes: Removed various redundant traits - StyleGuideController: Removed 7 redundant traits Key architectural findings: - ElementMediaThemeTrait includes ElementWrapThemeTrait - ElementNodeNewsThemeTrait includes multiple traits (EntityDateTrait, LineSeparatorThemeTrait, etc.) - Many theme traits follow hierarchical patterns with common base traits 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This comment was marked as spam.
This comment was marked as spam.
AronNovak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Summary