Skip to content

fix: consider a Windows resource untrusted if security information could not be retrieved (#2128) #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 31, 2025
Merged

fix: consider a Windows resource untrusted if security information could not be retrieved (#2128) #2147

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
641a89c
fix: consider a Windows resource untrusted if security information co…
Byron Aug 31, 2025
0bd262d
Improve description of the workaround.
Byron Aug 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion gix-sec/src/identity.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ mod impl_ {

pub fn is_path_owned_by_current_user(path: &Path) -> io::Result<bool> {
use windows_sys::Win32::{
Foundation::{GetLastError, LocalFree, ERROR_INSUFFICIENT_BUFFER, ERROR_SUCCESS},
Foundation::{GetLastError, LocalFree, ERROR_INSUFFICIENT_BUFFER, ERROR_INVALID_FUNCTION, ERROR_SUCCESS},
Security::{
Authorization::{GetNamedSecurityInfoW, SE_FILE_OBJECT},
CheckTokenMembership, EqualSid, GetTokenInformation, IsWellKnownSid, TokenOwner,
Expand Down Expand Up @@ -123,6 +123,11 @@ mod impl_ {
);

if result != ERROR_SUCCESS {
if result == ERROR_INVALID_FUNCTION {
// We cannot obtain security information, so we default to reduced trust
// (false) rather than failing completely.
return Ok(false);
}
let inner = io::Error::from_raw_os_error(result as _);
error!(
inner,
Expand Down
Loading