-
Notifications
You must be signed in to change notification settings - Fork 4k
Support for hidden sections #3831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for filtering out hidden sections and section groups from the site structure. The changes ensure that sections where all site spaces are hidden are excluded from the visible sections list, improving the user experience by not displaying inaccessible content.
- Introduced filtering logic to exclude sections with only hidden site spaces
- Added recursive filtering for section groups to handle nested structures
- Updated
parseSiteSectionsAndGroupsto apply the new filtering logic
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
conico974
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the right place to do that actually ? These sections are hidden in navigation only right ?
The context is used basically everywhere, and I'm wondering if removing stuff from here could actually break other parts like the sitemap for example
|
@conico974 it's enabled only for one customer and they don't really care about sitemap, it's already working for variants but I'll double check if it breaks anything for sections/groups |
No description provided.