Stop filtering by language when site space language is unspecified #3825
Conversation
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
zenoachtig
left a comment
zenoachtig
left a comment
There was a problem hiding this comment.
I don't understand the server-actions enough to review the refactor's impact. The language filter looks good
|
@zenoachtig Done. @codex review |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
utkuufuk
deleted the
utku/rnd-8664-spaces-with-undefined-language-are-not-included-in-search
branch
In the "extended" search scope, we currently exclude site spaces that do not have the same language as the current site space. However, the current site space or other site spaces might not always have a language specification.
This PR avoids doing the language-based filtering when either the current site space or the target site space has the language unspecified.
Additionally, it includes a refactoring that allows the parallelization of two asynchronous calls that are currently done sequentially.