-
Notifications
You must be signed in to change notification settings - Fork 4k
Support new object-fit property on individual card cover image #3594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new object-fit property on individual card cover image #3594
Conversation
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
a413cec to
2f6a134
Compare
nolannbiron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just need to update the types once the API changes are released
packages/gitbook/src/components/DocumentView/Table/RecordCard.tsx
Outdated
Show resolved
Hide resolved
packages/gitbook/src/components/DocumentView/Table/RecordCard.tsx
Outdated
Show resolved
Hide resolved
d8110f3 to
c9b9f0b
Compare
c9b9f0b to
d63a0ab
Compare
d63a0ab to
b86168f
Compare
This PR implements the GBO-side of allowing the object-fit property on cards. Table record fields for cover image now not only accept
api.ContentRefFile | api.ContentRefURL, but also an object that contains record-level configurations like object-fit where then the content ref will be nested:If an object-fit is used that results in the background of the card being visible, we apply a subtle bg tint-color of the configured customization styles.
see https://github.com/GitbookIO/gitbook-x/pull/19221
Preview
CleanShot.2025-08-25.at.09.40.03.mp4