Use "exit 1" to abort if branch-deploy fails

[kevinbackhouse]

Separating into two separate jobs (#107) doesn't work well, because any error messages from the second job don't get reported back as comments on the issue.

This is a cruder solution that will hopefully work better.

[Copilot]

Pull request overview

This PR consolidates the smoketest workflow from two separate jobs into a single job to ensure error messages from branch-deploy are properly reported as PR comments. Instead of using job dependencies and outputs to control execution, it now uses an explicit check with exit 1 to abort the job if branch-deploy fails.

Key Changes:

• Merged permission-check and run-tests jobs into a single Linux job
• Added an explicit shell script check that exits with error code 1 if branch-deploy doesn't return true

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[kevinbackhouse]

@JarLob has pointed out that this will cause the workflow to fail on almost every issue comment, which will generate a huge number of notifications. Closing.