Skip to content

Update synthetics config to exclude test dir #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2025
Merged

Update synthetics config to exclude test dir #131

merged 1 commit into from
May 21, 2025

Conversation

@GeekMasher
Copy link
Contributor

@GeekMasher GeekMasher commented May 15, 2025

No description provided.

@GeekMasher GeekMasher requested review from Copilot and felickz May 15, 2025 13:19
Copilot AI reviewed May 15, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the synthetics configuration to ignore the test/ directory in addition to existing patterns.

  • Adds "test/**" under paths-ignore in configs/synthetics.yml to exclude the singular test folder.

@felickz
Copy link
Contributor

felickz commented May 15, 2025 •
edited
Loading

Have a scenario where a test/ folder has something other then tests in it?

misunderstood the change

@GeekMasher
Copy link
Contributor Author

GeekMasher commented May 15, 2025

@felickz only seen test code in projects like:

https://github.com/juice-shop/juice-shop/tree/master/test

@felickz felickz changed the title Update synthetics config to remove test dir Update synthetics config to exclude test dir May 21, 2025
felickz
felickz approved these changes May 21, 2025
View reviewed changes
Copy link
Contributor

@felickz felickz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@felickz felickz merged commit 2b5b6ca into main May 21, 2025
15 checks passed
@felickz felickz deleted the GeekMasher-patch-1 branch May 21, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@felickz felickz felickz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GeekMasher @felickz