Skip to content

Conversation

@kash-jay
Copy link
Contributor

Added missing tags: "PUBLIC", "VAULTED", "REVOCABLE_BY_GG".

@kash-jay kash-jay self-assigned this Nov 14, 2025
@kash-jay kash-jay requested a review from a team as a code owner November 14, 2025 10:37
@linear
Copy link

linear bot commented Nov 14, 2025

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.63%. Comparing base (e2f0498) to head (cb7e4c0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #159   +/-   ##
=======================================
  Coverage   95.63%   95.63%           
=======================================
  Files           5        5           
  Lines        1236     1236           
=======================================
  Hits         1182     1182           
  Misses         54       54           
Flag Coverage Δ
unittests 95.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

"CHECK_RUN_SKIP_TEST_CRED",
"IGNORED_IN_CHECK_RUN",
"FALSE_POSITIVE",
"PUBLIC",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried removing Tag entirely and replacing it with str instead? This would be more future-proof and I don't think it would break anything.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried it out, seems to work on py-gg

@kash-jay kash-jay closed this Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants