Support dependent nodesets for types codegen #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
einarmo
force-pushed
the
types-codegen-dependent-nodesets
branch
from
346eb7a to
0a5efb0
Compare
svanharmelen
approved these changes
Dec 3, 2025
This is a relatively simple implementation of this. Let users list dependent nodesets with import paths, like we allow for events. When actually generating the types, we store this as a map from namespace to import path, and during loading we just get the namespace of the type being loaded. This only really works for nodeset2 files, but since there exists a workaround, this isn't critical. We can improve on this in the future. With the codegen tests we can actually test stuff like this, which is quite nice.
einarmo
force-pushed
the
types-codegen-dependent-nodesets
branch
from
0a5efb0 to
3f907ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively simple implementation of this. Let users list dependent nodesets with import paths, like we allow for events. When actually generating the types, we store this as a map from namespace to import path, and during loading we just get the namespace of the type being loaded.
This only really works for nodeset2 files, but since there exists a workaround, this isn't critical. We can improve on this in the future.
With the codegen tests we can actually test stuff like this, which is quite nice.
This should fix #159.